Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-38079

Bump cluster-ingress-operator to client-go v0.30 and controller-runtime v0.18

XMLWordPrintable

    • Important
    • None
    • 2
    • NE Sprint 257, NE Sprint 258
    • 2
    • Rejected
    • False
    • Hide

      None

      Show
      None
    • N/A
    • Release Note Not Required
    • Done

      Description of problem

      The cluster-ingress-operator repository vendors controller-runtime v0.17.3, which uses Kubernetes 1.29 packages. The cluster-ingress-operator repository also vendors k8s.io/client-go v0.29.0. However, OpenShift 4.17 is based on Kubernetes 1.30.

      Version-Release number of selected component (if applicable)

      4.17.

      How reproducible

      Always.

      Steps to Reproduce

      Check https://github.com/openshift/cluster-ingress-operator/blob/release-4.17/go.mod.

      Actual results

      The sigs.k8s.io/controller-runtime package is at v0.17.3, and the k8s.io/client-go package is at v0.29.0.

      Expected results

      The sigs.k8s.io/controller-runtime package is at v0.18.0 or newer, and k8s.io/client-go is at v0.30.0 or newer. The k8s.io/client-go package version should match other k8s.io packages, such as k8s.io/api.

      Additional info

      https://github.com/openshift/cluster-ingress-operator/pull/1046 already bumped the k8s.io/* packages other than k8s.io/client-go to v0.29.0. Presumably k8s.io/client-go was missed by accident because of a replace rule in go.mod. In general, k8s.io/client-go should be at the same version as k8s.io/api and other k8s.io/* packages, and the controller-runtime package should be bumped to a version that uses the same minor version of the k8s.io/* packages.

      The controller-runtime v0.18 release includes some breaking changes; see the release notes at https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.0.

            mmasters1@redhat.com Miciah Masters
            mmasters1@redhat.com Miciah Masters
            Hongan Li Hongan Li
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: