Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-38072

[GCP] some inconsistency in Machine API document for Sample GCP MachineSet

XMLWordPrintable

    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • Low
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description of problem:

          The doc https://docs.openshift.com/container-platform/4.16/machine_management/creating_machinesets/creating-machineset-gcp.html#machineset-yaml-gcp_creating-machineset-gcp  gives Sample GCP MachineSet values
      But there are some places are inconsistency.
      
      1.
        name: <infrastructure_id>-w-a
            machine.openshift.io/cluster-api-machineset: <infrastructure_id>-w-a
              machine.openshift.io/cluster-api-machineset: <infrastructure_id>-w-a
      
      
      I think it’s better to change <infrastructure_id>-w-a to <infrastructure_id>-worker-a, then it can keep consistent with the previous part
      
      
      $ oc -n openshift-machine-api \
        -o jsonpath='{.spec.template.spec.providerSpec.value.disks[0].image}{"\n"}' \
        get machineset/<infrastructure_id>-worker-a
      

      Note: Consolidating the apiVersion fixes into one bug under OCPBUGS-55123

      2.
            providerSpec:
              value:
                apiVersion: gcpprovider.openshift.io/v1beta1
      
      Here gcpprovider.openshift.io/v1beta1 should be changed to machine.openshift.io/v1beta1, because I checked on a 4.16 GCP cluster, it shows machine.openshift.io/v1beta1 in the default machineset, not sure why here is gcpprovider.openshift.io/v1beta1 in the doc.
      
      
      3.
      
      2 For <node>, specify the node label to add.
      
      Seems <node> should be changed to <role>, because it's <role> for 2 in the sample machineset values.  
              machine.openshift.io/cluster-api-machine-role: <role> 2 

      Version-Release number of selected component (if applicable):

          4.16

      How reproducible:

          

      Steps to Reproduce:

          1.
          2.
          3.
          

      Actual results:

          

      Expected results:

          

      Additional info:

          

              jrouth@redhat.com Jeana Routh
              huliu@redhat.com Huali Liu
              None
              None
              Huali Liu Huali Liu
              None
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: