-
Bug
-
Resolution: Done
-
Undefined
-
None
-
4.16
-
Moderate
-
None
-
3
-
False
-
The configuration for connection health checks added by OSDOCS-8766 contain an empty example that don't properly explain how to setup node selectors or tolerations.
It exemplifies the configuration only like this:
apiVersion: config.openshift.io/v1 kind: Network metadata: name: cluster spec: # ... networkDiagnostics: mode: "" sourcePlacement: {} targetPlacement: {}
That way, no user can imagine that you have to specify either nodeSelector or tolerations fields or both.
It should contain a more realistic example, where both sourcePlacement and targetPlacement do specify concrete node selectors and concrete tolerations.
Like this:
apiVersion: config.openshift.io/v1 kind: Network metadata: name: cluster spec: # ... networkDiagnostics: mode: "All" sourcePlacement: nodeSelector: checkNodes: groupA tolerations: - key: myTaint effect: NoSchedule operator: Exists targetPlacement: nodeSelector: checkNodes: groupB tolerations: - key: myOtherTaint effect: NoExecute operator: Exists
Properly explaining that both nodeSelector and tolerations are optional, i.e. that you don't necessarily need to specify both of them for both sourceNode and targetNode but you can omit some.
- links to
