Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-36969

[4.16] globalMaxSnapshotsPerBlockVolume not configurable

XMLWordPrintable

    • +
    • Important
    • None
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously, you could not change the snapshot limits for the {vmw-first} Container Storage Interface (CSI) driver without enabling the `TechPreviewNoUpgrade` feature gate because of a missing API that caused a bug with the Cluster Storage Operator.With this release, the missing API is added so that you can now change the snapshot limits without having to enable the `TechPreviewNoUpgrade` feature gate. For more information about changing the snapshot limits, see xref:../storage/container_storage_interface/persistent-storage-csi-vsphere.html#vsphere-change-max-snapshot_persistent-storage-csi-vsphere[Changing the maximum number of snapshots for vSphere] (link:https://issues.redhat.com/browse/OCPBUGS-36969[*OCPBUGS-36969*])
      Show
      * Previously, you could not change the snapshot limits for the {vmw-first} Container Storage Interface (CSI) driver without enabling the `TechPreviewNoUpgrade` feature gate because of a missing API that caused a bug with the Cluster Storage Operator.With this release, the missing API is added so that you can now change the snapshot limits without having to enable the `TechPreviewNoUpgrade` feature gate. For more information about changing the snapshot limits, see xref:../storage/container_storage_interface/persistent-storage-csi-vsphere.html#vsphere-change-max-snapshot_persistent-storage-csi-vsphere[Changing the maximum number of snapshots for vSphere] (link: https://issues.redhat.com/browse/OCPBUGS-36969 [* OCPBUGS-36969 *])
    • Bug Fix
    • Done

      Description of problem:

      • Not able to configurable the `globalMaxSnapshotsPerBlockVolume`

      -  As per official doc this feature is configuration.
      https://docs.openshift.com/container-platform/4.16/storage/container_storage_interface/persistent-storage-csi-vsphere.html#vsphere-change-max-snapshot_persistent-storage-csi-vsphere

      • Please see the below testing result.
        Before Patch:
        
        $ ./oc -n openshift-cluster-csi-drivers get cm/vsphere-csi-config -o yaml
        apiVersion: v1
        data:
          cloud.conf: |
            # Labels with topology values are added dynamically via operator
            [Global]
            cluster-id = ci-ln-1pd7szb-c1627-cbtd8
        
            [VirtualCenter "vcenter-1.ci.ibmc.devcluster.openshift.com"]
            insecure-flag           = true
            datacenters             = cidatacenter-2
            migration-datastore-url = ds:///vmfs/volumes/vsan:52eb63e99ce26f5b-b5ba4b2484169430/
        kind: ConfigMap
        metadata:
          creationTimestamp: "2024-07-12T04:54:31Z"
          name: vsphere-csi-config
          namespace: openshift-cluster-csi-drivers
          resourceVersion: "8172"
          uid: b1a4cf21-8416-4dc2-a3b5-2abe887dbe4f
        
        Patch command:
        
        $ ./oc patch clustercsidriver/csi.vsphere.vmware.com --type=merge -p '{"spec":{"driverConfig":{"vSphere":{"globalMaxSnapshotsPerBlockVolume": 10}}}}'
        Warning: unknown field "spec.driverConfig.vSphere.globalMaxSnapshotsPerBlockVolume"
        clustercsidriver.operator.openshift.io/csi.vsphere.vmware.com patched
        
        $ ./oc -n openshift-cluster-csi-drivers get cm/vsphere-csi-config -o yaml
        apiVersion: v1
        data:
          cloud.conf: |
            # Labels with topology values are added dynamically via operator
            [Global]
            cluster-id = ci-ln-1pd7szb-c1627-cbtd8
        
            [VirtualCenter "vcenter-1.ci.ibmc.devcluster.openshift.com"]
            insecure-flag           = true
            datacenters             = cidatacenter-2
            migration-datastore-url = ds:///vmfs/volumes/vsan:52eb63e99ce26f5b-b5ba4b2484169430/
        kind: ConfigMap
        metadata:
          creationTimestamp: "2024-07-12T04:54:31Z"
          name: vsphere-csi-config
          namespace: openshift-cluster-csi-drivers
          resourceVersion: "8172"
          uid: b1a4cf21-8416-4dc2-a3b5-2abe887dbe4f
        
        $ ./oc get clusterversion
        NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
        version   4.16.2    True        False         11m     Cluster version is 4.16.2 
      • Got same result with OCP v4.16.1

      Also can you confirm if this is TP or GA feature?
      As per the https://github.com/openshift/enhancements/blob/master/enhancements/storage/vsphere-driver-configuration.md?plain=1#L154
      I see it still in enhancement and in TP
      ~~~

          1. Graduation Criteria| OpenShift | Maturity     |
            ----------- --------------
            4.16      Tech Preview
            4.17      GA          

            ~~~

      https://redhat-internal.slack.com/archives/CBQHQFU0N/p1720768379160209

            rbednar@redhat.com Roman Bednar
            rhn-support-smulje Swati Mulje
            Penghao Wang Penghao Wang
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: