Description of problem:
When set minVersion bigger than maxVersion for ocp release setting, no error message , and collecting release images result is 0 image.
Version-Release number of selected component (if applicable):
./oc-mirror.latest version WARNING: This version information is deprecated and will be replaced with the output from --short. Use --output=yaml|json to get the full version. Client Version: version.Info{Major:"", Minor:"", GitVersion:"4.17.0-202406131541.p0.g157eb08.assembly.stream.el9-157eb08", GitCommit:"157eb085db0ca66fb689220119ab47a6dd9e1233", GitTreeState:"clean", BuildDate:"2024-06-13T17:25:46Z", GoVersion:"go1.22.1 (Red Hat 1.22.1-1.el9) X:strictfipsruntime", Compiler:"gc", Platform:"linux/amd64"}
How reproducible:
always
Steps to Reproduce:
1) with following isc: apiVersion: mirror.openshift.io/v2alpha1 kind: ImageSetConfiguration mirror: additionalImages: - name: quay.io/openshifttest/bench-army-knife@sha256:078db36d45ce0ece589e58e8de97ac1188695ac155bc668345558a8dd77059f6 platform: channels: - name: stable-4.15 type: ocp minVersion: '4.15.11' maxVersion: '4.15.10' graph: true
Actual results:
No validation for the imagesetconfig : ./oc-mirror.latest -c config-19.yaml --v2 file://out19 2024/06/19 08:15:43 [WARN] : ⚠️ --v2 flag identified, flow redirected to the oc-mirror v2 version. This is Tech Preview, it is still under development and it is not production ready. 2024/06/19 08:15:43 [INFO] : 👋 Hello, welcome to oc-mirror 2024/06/19 08:15:43 [INFO] : ⚙️ setting up the environment for you... 2024/06/19 08:15:43 [INFO] : 🔀 workflow mode: mirrorToDisk 2024/06/19 08:15:43 [INFO] : 🕵️ going to discover the necessary images... 2024/06/19 08:15:43 [INFO] : 🔍 collecting release images... 2024/06/19 08:15:49 [INFO] : 🔍 collecting operator images... 2024/06/19 08:16:27 [INFO] : 🔍 collecting additional images... 2024/06/19 08:16:27 [INFO] : 🚀 Start copying the images... 2024/06/19 08:16:27 [INFO] : === Overall Progress - image 1 / 11 === 2024/06/19 08:16:27 [INFO] : release image 1 / 1 2024/06/19 08:16:27 [INFO] : operator image 0 / 9 2024/06/19 08:16:27 [INFO] : additional image 0 / 1
Expected results:
should check the imagesetconfig firstly, and prompt the minVersion should not bigger than maxVersion.