-
Bug
-
Resolution: Done-Errata
-
Critical
-
None
-
4.17
-
Critical
-
No
-
Proposed
-
False
-
Description of problem:
No infraID generated automatically and we can not delete infra resources by infraID anymore.
InfraID was generated automatically previously. If it is a new change that users must set --infra-id as the parameter, we should add validation to block the infra resources creation without this parameter.
$ hypershift create cluster aws \
> --name=heli-test \
> --pull-secret=/Users/harry/pull-secret \
> --aws-creds=/Users/harry/.aws/credentials \
> --node-pool-replicas=1 \
> --region=us-east-2 \
> --base-domain=qe.devcluster.openshift.com \
> '--annotations=hypershift.openshift.io/cleanup-cloud-resources="true"' \
> --ssh-key=/Users/harry/.ssh/id_rsa.pub \
> --namespace=clusters \
> --release-image=registry.ci.openshift.org/ocp/release@sha256:0f23da293ac6d1ce8a588ac16a2bbe78353becf8efd7013a1ee60271f5768da3
Flag --aws-creds has been deprecated, please use '--sts-creds' with '--role-arn' instead
2024-06-14T12:38:02+08:00 INFO Creating infrastructure {"id": ""}
2024-06-14T12:38:04+08:00 INFO Using zone {"zone": "us-east-2a"}
2024-06-14T12:38:05+08:00 INFO Found existing VPC {"id": "vpc-0ba7f1b85c3dcf459"}
2024-06-14T12:38:05+08:00 INFO Enabled DNS support on VPC {"id": "vpc-0ba7f1b85c3dcf459"}
2024-06-14T12:38:05+08:00 INFO Enabled DNS hostnames on VPC {"id": "vpc-0ba7f1b85c3dcf459"}
2024-06-14T12:38:06+08:00 INFO Found existing DHCP options {"id": "dopt-08731b01fbd92d528"}
2024-06-14T12:38:06+08:00 INFO Associated DHCP options with VPC {"vpc": "vpc-0ba7f1b85c3dcf459", "dhcp options": "dopt-08731b01fbd92d528"}
2024-06-14T12:38:06+08:00 INFO Found existing internet gateway {"id": "igw-0760e032133e92bac"}
2024-06-14T12:38:07+08:00 INFO Found existing subnet {"name": "-private-us-east-2a", "id": "subnet-09dc8ca6ed991bbb9"}
2024-06-14T12:38:07+08:00 INFO Found existing subnet {"name": "-public-us-east-2a", "id": "subnet-03c1b46b5538fe3e1"}
2024-06-14T12:38:08+08:00 INFO Found existing NAT gateway {"id": "nat-05fd45e7467d2115c"}
2024-06-14T12:38:08+08:00 INFO Found existing route table {"name": "-private-us-east-2a", "id": "rtb-083b27f54f31ebd78"}
2024-06-14T12:38:08+08:00 INFO Found existing route to NAT gateway {"route table": "rtb-083b27f54f31ebd78", "nat gateway": "nat-05fd45e7467d2115c"}
2024-06-14T12:38:08+08:00 INFO Associated subnet with route table {"route table": "rtb-083b27f54f31ebd78", "subnet": "subnet-09dc8ca6ed991bbb9"}
2024-06-14T12:38:09+08:00 INFO Found existing route table {"name": "-public", "id": "rtb-062e7cde73a0111a9"}
2024-06-14T12:38:09+08:00 INFO Found existing route to internet gateway {"route table": "rtb-062e7cde73a0111a9", "internet gateway": "igw-0760e032133e92bac"}
2024-06-14T12:38:10+08:00 INFO Associated route table with subnet {"route table": "rtb-062e7cde73a0111a9", "subnet": "subnet-03c1b46b5538fe3e1"}
2024-06-14T12:38:10+08:00 INFO Found existing s3 VPC endpoint {"id": "vpce-0fd6b2fc6444defe9"}
2024-06-14T12:38:19+08:00 INFO Found existing public zone {"name": "qe.devcluster.openshift.com", "id": "Z3B3KOVA3TRCWP"}
2024-06-14T12:38:26+08:00 INFO Created private zone {"name": "heli-test.qe.devcluster.openshift.com", "id": "Z0731753JTRC39NKTLG5"}
2024-06-14T12:38:37+08:00 INFO Created private zone {"name": "heli-test.hypershift.local", "id": "Z0432848OSN1I5WQCTHI"}
panic: bucket: "aos-hypershift-ci-oidc-290517", region: "us-east-2", infraID: ""
goroutine 1 [running]:
github.com/openshift/hypershift/cmd/infra/aws.oidcDiscoveryURL({0xc001234520, 0x1d}, {0xc00122ed00, 0x9}, {0x0, 0x0})
/Users/harry/gopath/src/github.com/openshift/hypershift/cmd/infra/aws/create_iam.go:205 +0x37e
github.com/openshift/hypershift/cmd/infra/aws.(*CreateIAMOptions).CreateOIDCResources(0xc000b8e7b0, {0xf2870a0, 0xc000cc01c8})
/Users/harry/gopath/src/github.com/openshift/hypershift/cmd/infra/aws/iam.go:442 +0x105
github.com/openshift/hypershift/cmd/infra/aws.(*CreateIAMOptions).CreateIAM(0xc000b8e7b0, {0xf2242c8, 0xc000e5e000}, {0xf231900, 0xc0004f7d40})
/Users/harry/gopath/src/github.com/openshift/hypershift/cmd/infra/aws/create_iam.go:173 +0xa26
github.com/openshift/hypershift/cmd/cluster/aws.(*CreateOptions).Complete(0xc000e3eb00, {0xf2242c8, 0xc000e5e000}, 0xc000e3a848)
/Users/harry/gopath/src/github.com/openshift/hypershift/cmd/cluster/aws/create.go:137 +0x1035
github.com/openshift/hypershift/cmd/cluster/core.CreateCluster({0xf2242c8, 0xc000e5e000}, 0xc000e3a848, {0xf2258d8, 0xc000e3eb00})
/Users/harry/gopath/src/github.com/openshift/hypershift/cmd/cluster/core/create.go:594 +0x10e
github.com/openshift/hypershift/cmd/cluster/aws.CreateCluster({0xf2242c8, 0xc000e5e000}, 0xc000e3a848, 0xc000e3eb00)
/Users/harry/gopath/src/github.com/openshift/hypershift/cmd/cluster/aws/create.go:398 +0x89
github.com/openshift/hypershift/cmd/cluster/aws.NewCreateCommand.func1(0xc000e62308, {0xc000e97720, 0x0, 0xa})
/Users/harry/gopath/src/github.com/openshift/hypershift/cmd/cluster/aws/create.go:384 +0x225
github.com/spf13/cobra.(*Command).execute(0xc000e62308, {0xc00014e040, 0xa, 0xa})
/Users/harry/gopath/src/github.com/openshift/hypershift/vendor/github.com/spf13/cobra/command.go:983 +0xfca
github.com/spf13/cobra.(*Command).ExecuteC(0xc000ddf208)
/Users/harry/gopath/src/github.com/openshift/hypershift/vendor/github.com/spf13/cobra/command.go:1115 +0x9d0
github.com/spf13/cobra.(*Command).Execute(0xc000ddf208)
/Users/harry/gopath/src/github.com/openshift/hypershift/vendor/github.com/spf13/cobra/command.go:1039 +0x32
github.com/spf13/cobra.(*Command).ExecuteContext(0xc000ddf208, {0xf2242c8, 0xc000e5e000})
/Users/harry/gopath/src/github.com/openshift/hypershift/vendor/github.com/spf13/cobra/command.go:1032 +0x73
main.main()
/Users/harry/gopath/src/github.com/openshift/hypershift/main.go:78 +0x848
Version-Release number of selected component (if applicable):
4.17
How reproducible:
100%
Steps to Reproduce:
see the issue description
Actual results:
creation failed due to the lack of the infraID
Expected results:
hc can be created successfully
Additional info:
$ hypershift -v
hypershift version openshift/hypershift: 2b6f01a6f93c6dd79f265848bd3005e7421a969c. Latest supported OCP: 4.17.0
$ oc logs -n hypershift -c operator -lapp=operator --tail=-1 | head -1
{"level":"info","ts":"2024-06-14T02:08:32Z","logger":"setup","msg":"Starting hypershift-operator-manager","version":"openshift/hypershift: 2b6f01a6f93c6dd79f265848bd3005e7421a969c. Latest supported OCP: 4.17.0"}
# no related error logs found in HO
$ oc logs -n hypershift -c operator -lapp=operator --tail=-1 | grep -i error | grep -v "the object has been modified" | grep -v metrics
2024/06/14 02:10:32 http: TLS handshake error from 10.129.0.2:33222: EOF
2024/06/14 02:10:24 http: TLS handshake error from 10.129.0.2:40172: EOF
2024/06/14 02:10:24 http: TLS handshake error from 10.129.0.2:40176: EOF
{"level":"info","ts":"2024-06-14T02:10:27Z","msg":"Warning: Reconciler returned both a non-zero result and a non-nil error. The result will always be ignored if the error is non-nil and the non-nil error causes reqeueuing with exponential backoff. For more details, see: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/reconcile#Reconciler","controller":"hostedcluster","controllerGroup":"hypershift.openshift.io","controllerKind":"HostedCluster","HostedCluster":{"name":"hypershift-ci-290517","namespace":"clusters"},"namespace":"clusters","name":"hypershift-ci-290517","reconcileID":"5e2273fe-4af4-4f57-a118-7d6048c316db"}
- links to
-
RHEA-2024:3718
OpenShift Container Platform 4.17.z bug fix update