Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-35312

aws: rename `preserverBootstrapIgnition` install-config option

XMLWordPrintable

    • No
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously, there was a `preserveBootstrapIgnition` field for AWS in the `istall-config.yaml` file. With this release, the `preserveBootstrapIgnition` field has been deprecated and renamed to `bestEffortDeleteIgnition`. (link:https://issues.redhat.com/browse/OCPBUGS-35312[*OCPBUGS-35312*])
      Show
      * Previously, there was a `preserveBootstrapIgnition` field for AWS in the `istall-config.yaml` file. With this release, the `preserveBootstrapIgnition` field has been deprecated and renamed to `bestEffortDeleteIgnition`. (link: https://issues.redhat.com/browse/OCPBUGS-35312 [* OCPBUGS-35312 *])
    • Deprecated Functionality
    • Done

      This is a clone of issue OCPBUGS-33661. The following is the description of the original issue:
      —
      Description of problem:

      `preserveBootstrapIgnition` was named after the implementation details in terraform for how to make deleting S3 objects optional. The motivation behind the change was that some customers run installs in subscriptions where policies do not allow deleting s3 objects. They didn't want the install to fail because of that.

With the move from terraform to capi/capa, this is now implemented differently: capa always tries to delete the s3 objects but will ignore any permission errors if `preserveBootstrapIgnition` is set.

We should rename this option so it's clear that the objects will be deleted if there are enough permissions. My suggestion is to name something similar to what's named in CAPA: `allowBestEffortDeleteIgnition`.

Ideally we should deprecate `preserveBootstrapIgnition` in 4.16 and remove it in 4.17.

      Version-Release number of selected component (if applicable):

          4.14+ but I don't think we want to change this for terraform-based installs

      How reproducible:

          always

      Steps to Reproduce:

          1.
    2.
    3.

      Actual results:

      Expected results:

      Additional info:

          https://github.com/openshift/installer/pull/7288

              rdossant Rafael Fonseca dos Santos
              openshift-crt-jira-prow OpenShift Prow Bot
              Yunfei Jiang Yunfei Jiang
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: