Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-35217

Release Notes Pipelines 1.14: Incorrect example for default resource requirements

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • 4.14
    • None
    • Low
    • None
    • False
    • Hide

      None

      Show
      None

      Description of problem:

      In the Release notes for Red Hat OpenShift Pipelines General Availability 1.14 there is the following section (https://docs.openshift.com/pipelines/1.14/about/op-release-notes.html#new-features-1-14_op-release-notes):
      
      ~~~
      With this update, you can define default resource requirements for containers and init-containers in pods that OpenShift Pipelines creates when executing task runs. Use the pipeline.options.configMaps.config-defaults.default-container-resource-requirements spec in the TektonConfig CR to set these requirements. You can set the default values for all containers and also for particular containers by name or by prefix, such as sidecar-*.
      ~~~
      
      However the field described does not work as expected. When trying to use `oc patch` to add content to such a field the user will get an error like this:
      
      ~~~
      Error from server (BadRequest): admission webhook "webhook.operator.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "default-container-resource-requirements"
      ~~~
      
      The correct path is `pipeline.options.configMaps.config-defaults.data.default-container-resource-requirements` (note the `data` field). So an example patch command could be:
      
      ~~~
      oc patch TektonConfig/config  --type merge -p '{"spec": {"pipeline": {"options": {"configMaps": {"config-defaults": {"data": {"default-container-resource-requirements": "{\"requests\": {\"memory\": \"64Mi\"}}"}}}}}}}'
      ~~~

      Version-Release number of selected component (if applicable):

      OpenShift Container Platform 4.14
      Pipelines 1.14

      How reproducible:

      Always

      Steps to Reproduce:

      1. Install OpenShift Container Platform 4.14 with Pipelines 1.14
      2. Try to apply a change to the field outlined in the documentation
      

      Actual results:

      Fails with `json: unknown field "default-container-resource-requirements"`

      Expected results:

      Documentation is correct

      Additional info:

      * Slack discussion: https://redhat-internal.slack.com/archives/CSPS1077U/p1709737546039279?thread_ts=1709735908.637209&cid=CSPS1077U

              mramendi Mikhail Ramendik
              rhn-support-skrenger Simon Krenger
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: