-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
4.15, 4.16.0, 4.17.0
-
Low
-
No
-
NE Sprint 256
-
1
-
Rejected
-
False
-
-
-
Bug Fix
-
In Progress
Description of problem:
Cluster-ingress-operator logs an update when one didn't happen.
% grep -e 'successfully updated Infra CR with Ingress Load Balancer IPs' -m 1 -- ingress-operator.log 2024-05-17T14:46:01.434Z INFO operator.ingress_controller ingress/controller.go:326 successfully updated Infra CR with Ingress Load Balancer IPs % grep -e 'successfully updated Infra CR with Ingress Load Balancer IPs' -c -- ingress-operator.log 142
https://github.com/openshift/cluster-ingress-operator/pull/1016 has a logic error, which causes the operator to log this message even when it didn't do an update:
// If the lbService exists for the "default" IngressController, then update Infra CR's PlatformStatus with the Ingress LB IPs. if haveLB && ci.Name == manifests.DefaultIngressControllerName { if updated, err := computeUpdatedInfraFromService(lbService, infraConfig); err != nil { errs = append(errs, fmt.Errorf("failed to update Infrastructure PlatformStatus: %w", err)) } else if updated { if err := r.client.Status().Update(context.TODO(), infraConfig); err != nil { errs = append(errs, fmt.Errorf("failed to update Infrastructure CR after updating Ingress LB IPs: %w", err)) } } log.Info("successfully updated Infra CR with Ingress Load Balancer IPs") }
Version-Release number of selected component (if applicable):
4.17
How reproducible:
100%
Steps to Reproduce:
1. Create a LB service for the default Ingress Operator 2. Watch ingress operator logs for the search strings mentioned above
Actual results:
Lots of these log entries will be seen even though no further updates are made to the default ingress operator: 2024-05-17T14:46:01.434Z INFO operator.ingress_controller ingress/controller.go:326 successfully updated Infra CR with Ingress Load Balancer IPs
Expected results:
Only see this log entry when an update to Infra CR is made. Perhaps just one the first time you add a LB service to the default ingress operator.
Additional info:
https://github.com/openshift/cluster-ingress-operator/pull/1016 was backported to 4.15, so it would be nice to fix it and backport the fix to 4.15. It is rather noisy, and it's trivial to fix.
- blocks
-
OCPBUGS-39324 [Backport-4.16] Cluster-ingress-operator logs an update when one didn't happen
-
- POST
-
- is cloned by
-
OCPBUGS-39324 [Backport-4.16] Cluster-ingress-operator logs an update when one didn't happen
-
- POST
-
- links to
-
RHEA-2024:3718 OpenShift Container Platform 4.17.z bug fix update