Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-33775

Do not generate idms & itms if nothing has been mirrored

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Undefined Undefined
    • 4.16.0
    • 4.16
    • oc-mirror
    • Moderate
    • No
    • CLID Sprint 254
    • 1
    • False
    • Hide

      None

      Show
      None
    • Hide
      Bug Fix:
      Previously, when using the `--v2` flag, if no images were mirrored and some were skipped, empty `imds.yaml` and `itms.yaml` files were generated. With this update, the custom resource generation is only triggered when at least one image is successfully mirrored, preventing the creation of empty files.
      (link:https://issues.redhat.com/browse/OCPBUGS-33775[*OCPBUGS-33775*])
      Show
      Bug Fix: Previously, when using the `--v2` flag, if no images were mirrored and some were skipped, empty `imds.yaml` and `itms.yaml` files were generated. With this update, the custom resource generation is only triggered when at least one image is successfully mirrored, preventing the creation of empty files. (link: https://issues.redhat.com/browse/OCPBUGS-33775 [* OCPBUGS-33775 *])
    • Bug Fix
    • Done

      Description of problem:

      When images have been skipped and no images have been mirrored i see idms and itms are generated.
2024/05/15 15:38:25  [WARN]   : ⚠️  --v2 flag identified, flow redirected to the oc-mirror v2 version. This is Tech Preview, it is still under development and it is not production ready.
2024/05/15 15:38:25  [INFO]   : 👋 Hello, welcome to oc-mirror
2024/05/15 15:38:25  [INFO]   : ⚙️  setting up the environment for you...
2024/05/15 15:38:25  [INFO]   : 🔀 workflow mode: mirrorToMirror 
2024/05/15 15:38:25  [INFO]   : 🕵️  going to discover the necessary images...
2024/05/15 15:38:25  [INFO]   : 🔍 collecting release images...
2024/05/15 15:38:25  [INFO]   : 🔍 collecting operator images...
2024/05/15 15:38:25  [INFO]   : 🔍 collecting additional images...
2024/05/15 15:38:25  [WARN]   : [AdditionalImagesCollector] mirroring skipped : source image quay.io/cilium/cilium-etcd-operator:v2.0.7@sha256:04b8327f7f992693c2cb483b999041ed8f92efc8e14f2a5f3ab95574a65ea2dc has both tag and digest
2024/05/15 15:38:25  [WARN]   : [AdditionalImagesCollector] mirroring skipped : source image quay.io/coreos/etcd:v3.5.4@sha256:a67fb152d4c53223e96e818420c37f11d05c2d92cf62c05ca5604066c37295e9 has both tag and digest
2024/05/15 15:38:25  [INFO]   : 🚀 Start copying the images...
2024/05/15 15:38:25  [INFO]   : === Results ===
2024/05/15 15:38:25  [INFO]   : All release images mirrored successfully 0 / 0 ✅
2024/05/15 15:38:25  [INFO]   : All operator images mirrored successfully 0 / 0 ✅
2024/05/15 15:38:25  [INFO]   : All additional images mirrored successfully 0 / 0 ✅
2024/05/15 15:38:25  [INFO]   : 📄 Generating IDMS and ITMS files...
2024/05/15 15:38:25  [INFO]   : /app1/knarra/customertest1/working-dir/cluster-resources/idms-oc-mirror.yaml file created
2024/05/15 15:38:25  [INFO]   : 📄 Generating CatalogSource file...
2024/05/15 15:38:25  [INFO]   : mirror time     : 715.644µs
2024/05/15 15:38:25  [INFO]   : 👋 Goodbye, thank you for using oc-mirror
[fedora@preserve-fedora36 knarra]$ ls -l /app1/knarra/customertest1/working-dir/cluster-resources/idms-oc-mirror.yaml
-rw-r--r--. 1 fedora fedora 0 May 15 15:38 /app1/knarra/customertest1/working-dir/cluster-resources/idms-oc-mirror.yaml
[fedora@preserve-fedora36 knarra]$ cat /app1/knarra/customertest1/working-dir/cluster-resources/idms-oc-mirror.yaml

      Version-Release number of selected component (if applicable):

           4.16 oc-mirror

      How reproducible:

           Always

      Steps to Reproduce:

          1. Use the following imageSetConfig.yaml and run command `./oc-mirror --v2 -c /tmp/bug331961.yaml --workspace file:///app1/knarra/customertest1 docker://localhost:5000/bug331961 --dest-tls-verify=false`


   
cat /tmp/imageSetConfig.yaml
kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
mirror:
   additionalImages:
   - name: quay.io/cilium/cilium-etcd-operator:v2.0.7@sha256:04b8327f7f992693c2cb483b999041ed8f92efc8e14f2a5f3ab95574a65ea2dc
   - name: quay.io/coreos/etcd:v3.5.4@sha256:a67fb152d4c53223e96e818420c37f11d05c2d92cf62c05ca5604066c37295e9

      Actual results:

          Nothing will be mirrored and the images listed will be skipped as these images has both tag and digest but i see idms and itms empty files being generated

      Expected results:

           If nothing is mirrored, idms and itms files should not be generated.

      Additional info:

          https://issues.redhat.com/browse/OCPBUGS-33196

              skhoury@redhat.com Sherine Khoury
              knarra@redhat.com Rama Kasturi Narra
              ying zhou ying zhou
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: