New master will be created if add duplicated failuredomains in controlplanemachineset

New master will be created if add duplicated failuredomains in controlplanemachineset

4.12.0-0.nightly-2022-11-06-054655

Always

1. Update controlplanemachineset and add a duplicated failuredomains us-east-2a in the first position of failuredomains

      failureDomains:
        aws:
        - placement:
            availabilityZone: us-east-2a
          subnet:
            filters:
            - name: tag:Name
              values:
              - zhsun117-x6jjt-private-us-east-2a
            type: Filters
        - placement:
            availabilityZone: us-east-2a
          subnet:
            filters:
            - name: tag:Name
              values:
              - zhsun117-x6jjt-private-us-east-2a
            type: Filters
        - placement:
            availabilityZone: us-east-2b
          subnet:
            filters:
            - name: tag:Name
              values:
              - zhsun117-x6jjt-private-us-east-2b
            type: Filters
        - placement:
            availabilityZone: us-east-2c
          subnet:
            filters:
            - name: tag:Name
              values:
              - zhsun117-x6jjt-private-us-east-2c
            type: Filters
        platform: AWS
2.
3.

A new master will be created in duplicated zone us-east-2a and the old master in zone us-east-2c will be removed.
$ oc get machine                 
NAME                                     PHASE     TYPE         REGION      ZONE         AGE
zhsun117-x6jjt-master-0                  Running   m6i.xlarge   us-east-2   us-east-2a   5h37m
zhsun117-x6jjt-master-1                  Running   m6i.xlarge   us-east-2   us-east-2b   5h37m
zhsun117-x6jjt-master-w8785-2            Running   m6i.xlarge   us-east-2   us-east-2a   15m
zhsun117-x6jjt-worker-us-east-2a-nxn6j   Running   m6i.xlarge   us-east-2   us-east-2a   5h34m
zhsun117-x6jjt-worker-us-east-2b-7vmr8   Running   m6i.xlarge   us-east-2   us-east-2b   5h34m
zhsun117-x6jjt-worker-us-east-2c-2zwwv   Running   m6i.xlarge   us-east-2   us-east-2c   5h34m

I1107 08:28:56.243804       1 provider.go:416]  "msg"="Created machine" "controller"="controlplanemachineset" "failureDomain"="AWSFailureDomain{AvailabilityZone:us-east-2a, Subnet:{Type:Filters, Value:&[{Name:tag:Name Values:[zhsun117-x6jjt-private-us-east-2a]}]}}" "index"=2 "machineName"="zhsun117-x6jjt-master-lzs4c-2" "name"="zhsun117-x6jjt-master-4v8wl-2" "namespace"="openshift-machine-api" "reconcileID"="eec9a27c-4b7e-467a-b28c-6470c3068ab2" "updateStrategy"="RollingUpdate"

Cluster no update.

If add the duplicate failuredomains us-east-2a at the end in failuredomains, it does not trigger update.