Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-32803

Remove unnecessary assisted-service pre-flight validation on nmstate files

XMLWordPrintable

    • Low
    • No
    • False
    • Hide

      None

      Show
      None

      Description of problem:

      If the user provides some static network configuration for the hosts, this will be re-validated by assisted-service during the pre-flights validations. This is not required, and it could cause an issue if the nmstate version used by the user (on the host) is different from the one shipped within the agent-installer-api-server image.

      Version-Release number of selected component (if applicable):

          4.16.0

      How reproducible:

          

      Steps to Reproduce:

          1.
          2.
          3.
          

      Actual results:

          In case of mismatch, the installation may be stopped, and a validation failure is reported in output (when monitored via the openshift-install agent wait-for install-complete command)

      Expected results:

          If the initial validations performed during the openshift-install agent create image are fine for the provided static network configuration, then the installation should proceed as expected

      Additional info:

          It looks like that this code is not really required https://github.com/openshift/assisted-service/blob/a03cd2cc1da5defe4faaff3217f785622b20dbbd/cmd/agentbasedinstaller/register.go#L163 and the cause of the problem, so it could be removed

              bfournie@redhat.com Robert Fournier
              afasano@redhat.com Andrea Fasano
              Manoj Hans Manoj Hans
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: