-
Bug
-
Resolution: Done
-
Minor
-
None
-
premerge, 4.16.0
-
Moderate
-
None
-
False
-
Description of problem:
When we configure ImageBuilderType the machine-os-builder pod is restarted, but it handles the lease in a non-graceful way. machine-os-builder pod Logs: $ oc logs machine-os-builder-fb856c6f4-nvrvf I0415 15:59:33.756112 1 start.go:89] Options parsed: {kubeconfig:} I0415 15:59:33.756133 1 start.go:92] Version: machine-config-daemon-4.6.0-202006240615.p0-2682-g200c5f24-dirty (200c5f24043dee744f5b1680eb09cffcaa7d7a8f) I0415 15:59:33.756143 1 builder.go:93] Using in-cluster kube client config I0415 15:59:33.756369 1 leaderelection.go:122] The leader election gives 4 retries and allows for 30s of clock skew. The kube-apiserver downtime tolerance is 78s. Worst non-graceful lease acquisition is 2m43s. Worst graceful lease acquisition is {26s}. I0415 15:59:33.770262 1 leaderelection.go:250] attempting to acquire leader lease openshift-machine-config-operator/machine-os-builder... I0415 15:59:33.775174 1 leaderelection.go:354] lock is held by machine-os-builder-fb856c6f4-nvrvf_42ca8477-a939-4883-89f4-643b5dcfa7b0 and has not yet expired I0415 15:59:33.775195 1 leaderelection.go:255] failed to acquire lease openshift-machine-config-operator/machine-os-builder
Version-Release number of selected component (if applicable):
pre-merge: https://github.com/openshift/machine-config-operator/pull/4302
How reproducible:
Always
Steps to Reproduce:
1. Enable OCB functionality 2. Configure a new ImageBuilderType $ oc patch cm/on-cluster-build-config -n openshift-machine-config-operator -p '{"data":{"imageBuilderType": "custom-pod-builder"}}
Actual results:
The machine-os-builder pod does not release the lease before restarting and it executes a non-graceful acquisition waiting 2 minutes and a half after the restart
Expected results:
The lease acquisition should be executed in a graceful way.
Additional info:
- links to