Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-32164

HCP: hypershift-operator on disconnected clusters ignores ImageContentSourcePolicies when a ImageDigestMirrorSet exist on the management cluster

XMLWordPrintable

    • No
    • Hypershift Sprint 251, Hypershift Sprint 252
    • 2
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previosuly, in hosted control planes for {product-title}, when you created the custom resource definition (CRD) for `ImageDigestMirrorSet` and `ImageContentSourcePolicy` objects at the same time in a disconnected environment, the HyperShift Operator created the object only for the `ImageDigestMirrorSet` CRD, ignoring the `ImageContentSourcePolicy` CRD. With this release, the HyperShift Operator creates objects for the `ImageDigestMirrorSet` and `ImageContentSourcePolicy` CRDs. (link:https://issues.redhat.com/browse/OCPBUGS-32164[*OCPBUGS-32164*]
      Show
      * Previosuly, in hosted control planes for {product-title}, when you created the custom resource definition (CRD) for `ImageDigestMirrorSet` and `ImageContentSourcePolicy` objects at the same time in a disconnected environment, the HyperShift Operator created the object only for the `ImageDigestMirrorSet` CRD, ignoring the `ImageContentSourcePolicy` CRD. With this release, the HyperShift Operator creates objects for the `ImageDigestMirrorSet` and `ImageContentSourcePolicy` CRDs. (link: https://issues.redhat.com/browse/OCPBUGS-32164 [* OCPBUGS-32164 *]
    • Bug Fix
    • Done

      This is a clone of issue OCPBUGS-29466. The following is the description of the original issue:

      Description of problem:

          The design doc for ImageDigestMirrorSet states:
      "ImageContentSourcePolicy CRD will be marked as deprecated and will be supported during all of 4.x. Update and coexistence of ImageDigestMirrorSet/ ImageTagMirrorSet and ImageContentSourcePolicy is supported. We encourage users to move to IDMS while supporting both in the cluster, but will not remove ICSP in OCP 4.x.".
      see: https://github.com/openshift/machine-config-operator/blob/master/docs/ImageMirrorSetDesign.md#goals
      
      see also:
      https://github.com/openshift/enhancements/blob/master/enhancements/api-review/add-new-CRD-ImageDigestMirrorSet-and-ImageTagMirrorSet-to-config.openshift.io.md#update-the-implementation-for-migration-path
      for the rationale behind it.
      
      but the hypershift-operator is reading ImageContentSourcePolicy only if no ImageDigestMirrorSet exists on the cluster, see:
      https://github.com/openshift/hypershift/blob/main/support/globalconfig/imagecontentsource.go#L101-L102
      
      

      Version-Release number of selected component (if applicable):

          4.14, 4.15, 4.16

      How reproducible:

          100%

      Steps to Reproduce:

          1. Set both an ImageContentSourcePolicy and ImageDigestMirrorSet with different content on the management cluster
          2.
          3.    

      Actual results:

      the hypershift-operator consumes only the ImageDigestMirrorSet content ignoring the ImageContentSourcePolicy one.    

      Expected results:

      since both ImageDigestMirrorSet and ImageContentSourcePolicy (although deprecated) are still supported on the management cluster, the hypershift-operator should align.    

      Additional info:

      currently oc-mirror (v1) is only generating imageContentSourcePolicy.yaml without any imageDigestMirrorSet.yaml equivalent breaking the hypershift disconnected scenario on clusters where an IDMS is already there for other reasons.    

            jparrill@redhat.com Juan Manuel Parrilla Madrid
            openshift-crt-jira-prow OpenShift Prow Bot
            He Liu He Liu
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: