Details
-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
4.9.z
-
None
-
No
-
False
-
Description
Description of problem:
The GitHub IDP admission CR validator does not correctly validate IP addresses. The issue is that when you use some invalid IP address for example 1.1.1.1.1 the kvalidation.IsDNS1123Subdomain matches it as a valid subdomain and the netutils.ParseIPSloppy is not called.
Version-Release number of selected component (if applicable):
afaik all for past 4 years
How reproducible:
Create GitHub IDP using invalid IP for example 1.1.1.1.1.1
Steps to Reproduce:
1. Create GitHub IDP using invalid IP for example 1.1.1.1.1.1 2. 3.
Actual results:
Updates oauth with the github idp
Expected results:
Throw error that the IP is not valid
Additional info: