Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-31329

NTO not modifying protectKernelDefaults when it is false

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Normal
    • None
    • 4.14
    • None
    • Important
    • No
    • False
    • Hide

      None

      Show
      None
    • 2024-04-10: Setting protectKernelDefaults=false is not supported per Ryan. Figuring out whether this false serialization issue is still something to fix.

    Description

      Description of problem:

      NTO not making the write changes when it comes to the kubeletconfig parameter: protectKernelDefaults.
      
      The object has an 'omitempty' clause on protectKernelDefaults, which means it won't serialize in golang to false.
      
      The above function in NTO will explicitly have to add that json stanza in https://github.com/openshift/cluster-node-tuning-operator/blob/master/pkg/performanceprofile/controller/performanceprofile/components/kubeletconfig/kubeletconfig.go#L47

      Version-Release number of selected component (if applicable):

          

      How reproducible:

          

      Steps to Reproduce:

          1. see OCPBUGS-31328
          2.
          3.
          

      Actual results:

          

      Expected results:

          

      Additional info:

          

      Attachments

        Activity

          People

            msivak@redhat.com Martin Sivak
            lhalleb@redhat.com Lazhar Halleb
            Liquan Cui Liquan Cui
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated: