Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-29484

openshift/images repository lacks a CI job to run unit tests

    XMLWordPrintable

Details

    • Important
    • No
    • Sprint 249, Sprint 250, Sprint 251
    • 3
    • Rejected
    • False
    • Hide

      None

      Show
      None
    • Release Note Not Required
    • In Progress

    Description

      Description of problem

      The egress-router implementations under https://github.com/openshift/images/tree/master/egress have unit tests alongside the implementations, within the same repository, but the repository does not have a CI job to run those unit tests. We do not have any tests for egress-router in https://github.com/openshift/origin. This means that we are effectively lacking CI test coverage for egress-router.

      Version-Release number of selected component (if applicable)

      All versions.

      How reproducible

      100%.

      Steps to Reproduce

      1. Open a PR in https://github.com/openshift/images and check which CI jobs are run on it.
      2. Check the job definitions in https://github.com/openshift/release/blob/master/ci-operator/jobs/openshift/images/openshift-images-master-presubmits.yaml.

      Actual results

      There are "ci/prow/e2e-aws", "ci/prow/e2e-aws-upgrade", and "ci/prow/images" jobs defined, but no "ci/prow/unit" job.

      Expected results

      There should be a "ci/prow/unit" job, and this job should run the unit tests that are defined in the repository.

      Additional info

      The lack of a CI job came up on https://github.com/openshift/images/pull/162.

      Attachments

        Issue Links

          Activity

            People

              amcdermo@redhat.com ANDREW MCDERMOTT
              mmasters1@redhat.com Miciah Masters
              Hongan Li Hongan Li
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: