Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-25764

OVN remove explicit memory-trim-on-compaction enable

XMLWordPrintable

    • No
    • SDN Sprint 249, SDN Sprint 250
    • 2
    • False
    • Hide

      None

      Show
      None

      Description of problem:

       

      From OCPBUGS-237 we discussed disabled memory-trim-on-compaction once it was enabled by default.

      On OCP with 4.15.0-0.nightly-2023-12-19-033450 we are at

      Red Hat Enterprise Linux CoreOS 415.92.202312132107-0 (Plow)
      openvswitch3.1-3.1.0-59.el9fdp.x86_64
      

      This should have memory-trim-on-compaction enabled by default

      v3.0.0 - 15 Aug 2022
      --------------------
           * Returning unused memory to the OS after the database compaction is now
             enabled by default.  Use 'ovsdb-server/memory-trim-on-compaction off'
             unixctl command to disable.
      

      https://github.com/openvswitch/ovs/commit/e773140ec3f6d296e4a3877d709fb26fb51bc6ee

      If we are enabled by default, we should remove the enable loop.

            # set trim-on-compaction
            if ! retry 60 "trim-on-compaction" "ovn-appctl -t ${nbdb_ctl} --timeout=5 ovsdb-server/memory-trim-on-compaction on"; then
              exit 1
            fi
      

      https://github.com/openshift/cluster-network-operator/blob/master/bindata/network/ovn-kubernetes/common/008-script-lib.yaml#L314
       

      Version-Release number of selected component (if applicable):

        4.15.0-0.nightly-2023-12-19-033450

      How reproducible:

       Always

      Steps to Reproduce:

      1. check if memory-trim-on-compaction is enabled by default in OVS

      2. check ndbd log files for

      Actual results:

       

      2023-12-20T18:12:47.053444489Z 2023-12-20T18:12:47.053Z|00002|ovsdb_server|INFO|ovsdb-server (Open vSwitch) 3.1.2
      2023-12-20T18:12:49.001580092Z 2023-12-20T18:12:49.001Z|00003|ovsdb_server|INFO|memory trimming after compaction enabled.
      

       

      Expected results:

       memory-trim-on-compaction should be enabled by default, we don't need to re-enable it.

      Affected Platforms:

      All

            rhn-support-arghosh Arnab Ghosh
            rbrattai@redhat.com Ross Brattain
            Ross Brattain Ross Brattain
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: