-
Bug
-
Resolution: Duplicate
-
Undefined
-
None
-
4.14, 4.15, 4.16
-
None
Description of problem:
Deploying 2 performance profiles on two different nodes, resulting in false priority warnings that were dumped to logs. As part of the profile selection process, NTO checks if there are profiles that share the same priority, regardless of their associated node!
Version-Release number of selected component (if applicable):
4.16
Steps to Reproduce:
1.Deploy a cluster with 2 nodes 2.Label each of the nodes with a unique label 3.Create MCP for each node 4.Deploy a performance profile for each node. 5.oc logs -f <nto-pod> -n openshift-cluster-node-tuning-operator
Actual results:
W1213 15:04:10.679528 1 profilecalculator.go:575] profiles openshift-node-performance-pp-worker-cnf/openshift-node-performance-pp-worker-cnf1 have the same priority 20, please use a different priority for your custom profiles!I1213 15:04:10.680623 1 status.go:303] 2/6 Profiles failed to be appliedW1213 15:04:15.746610 1 profilecalculator.go:575] profiles openshift-node-performance-pp-worker-cnf/openshift-node-performance-pp-worker-cnf1 have the same priority 20, please use a different priority for your custom profiles!W1213 15:04:15.765530 1 profilecalculator.go:575] profiles openshift-node-performance-pp-worker-cnf/openshift-node-performance-pp-worker-cnf1 have the same priority 20, please use a different priority for your custom profiles!I1213 15:04:15.768434 1 status.go:303] 2/6 Profiles failed to be applied
Expected results:
Proposed solution:
The current selection process for a profile is as follows: First, all profiles are collected, then we are checking for priority conflicts, and finally we are filtering for the associated node. A proper fix is to reverse the last 2 steps - first filter, then check for priority conflicts.