Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-24632

The configuration values of the CPMS generated by installer on vSphere is not the same with the master machines

    • Moderate
    • No
    • OpenShift SPLAT - Sprint 256, OpenShift SPLAT - Sprint 257, OpenShift SPLAT - Sprint 258, OpenShift SPLAT - Sprint 259
    • 4
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously, the `ControlPlaneMachineSet` (CPMS) checked templates and the resource pool based on the full vCenter path. This caused the CPMS to start when it was not needed. With this release, CPMS also checks the file name and the issue is resolved. (link:https://issues.redhat.com/browse/OCPBUGS-24632[*OCPBUGS-24632*])
      _____________
      Fixed issue where CPMS was checking templates and resource pool based on full path. This lead to rollout of control plane machine when no changes were needed.
      Show
      * Previously, the `ControlPlaneMachineSet` (CPMS) checked templates and the resource pool based on the full vCenter path. This caused the CPMS to start when it was not needed. With this release, CPMS also checks the file name and the issue is resolved. (link: https://issues.redhat.com/browse/OCPBUGS-24632 [* OCPBUGS-24632 *]) _____________ Fixed issue where CPMS was checking templates and resource pool based on full path. This lead to rollout of control plane machine when no changes were needed.
    • Bug Fix
    • Done

      Description of problem:

      The configuration values of the CPMS generated by installer on vSphere is not the same with the configuration values of the master machines, although it doesnโ€™t trigger update when installing the cluster with TechPreview, but itโ€™s confusing for users. 
      
      Another, if installing a cluster without TechPreview, then enable TechPreview for day2 operation, the CPMS is inactive by default, then only active CPMS and do not change other configuration values, it will trigger update, this is not as expected.
      
      Also, on other providers(AWS, GCP, Azure, Nutanix), the configuration values of the CPMS generated by installer is the same with the configuration values of the master machines.    

      Version-Release number of selected component (if applicable):

      4.15.0-0.nightly-2023-12-04-223539

      How reproducible:

      Always 

      Steps to Reproduce:

      1.Create a cluster on vSphere with TechPreview, we use flexy-template: ipi-on-vsphere/versioned-installer_techpreview, there is CPMS by default and itโ€™s Active.  
      liuhuali@Lius-MacBook-Pro huali-test % oc get clusterversion
      NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS
      version   4.15.0-0.nightly-2023-12-04-223539   True        False         6m1s    Cluster version is 4.15.0-0.nightly-2023-12-04-223539
      liuhuali@Lius-MacBook-Pro huali-test % oc project openshift-machine-api
      Already on project "openshift-machine-api" on server "https://api.huliu-vs07b.qe.devcluster.openshift.com:6443".
      liuhuali@Lius-MacBook-Pro huali-test % oc get machine
      NAME                               PHASE     TYPE   REGION   ZONE   AGE
      huliu-vs07b-pkm69-master-0         Running                          27m
      huliu-vs07b-pkm69-master-1         Running                          27m
      huliu-vs07b-pkm69-master-2         Running                          27m
      huliu-vs07b-pkm69-worker-0-5cgd9   Running                          21m
      huliu-vs07b-pkm69-worker-0-ql9zv   Running                          21m
      liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset
      NAME      DESIRED   CURRENT   READY   UPDATED   UNAVAILABLE   STATE    AGE
      cluster   3         3         3       3                       Active   27m   
      
      2.Check the configuration values in CPMS is not the same with the master machines. But they should be the same.
      liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset cluster -oyaml
      โ€ฆ
              providerSpec:
                value:
                  apiVersion: machine.openshift.io/v1beta1
                  credentialsSecret:
                    name: vsphere-cloud-credentials
                  diskGiB: 120
                  kind: VSphereMachineProviderSpec
                  memoryMiB: 16384
                  metadata:
                    creationTimestamp: null
                  network:
                    devices: null
                  numCPUs: 4
                  numCoresPerSocket: 4
                  snapshot: ""
                  template: ""
                  userDataSecret:
                    name: master-user-data
                  workspace: {}
      โ€ฆ
      liuhuali@Lius-MacBook-Pro huali-test % oc get machine huliu-vs07b-pkm69-master-2  -oyaml
      โ€ฆ
        providerSpec:
          value:
            apiVersion: machine.openshift.io/v1beta1
            credentialsSecret:
              name: vsphere-cloud-credentials
            diskGiB: 120
            kind: VSphereMachineProviderSpec
            memoryMiB: 16384
            metadata:
              creationTimestamp: null
            network:
              devices:
              - networkName: devqe-segment-221
            numCPUs: 4
            numCoresPerSocket: 4
            snapshot: ""
            template: huliu-vs07b-pkm69-rhcos-generated-region-generated-zone
            userDataSecret:
              name: master-user-data
            workspace:
              datacenter: DEVQEdatacenter
              datastore: /DEVQEdatacenter/datastore/vsanDatastore
              folder: /DEVQEdatacenter/vm/huliu-vs07b-pkm69
              resourcePool: /DEVQEdatacenter/host/DEVQEcluster//Resources
              server: vcenter.devqe.ibmc.devcluster.openshift.com
      โ€ฆ
      
      Must-gather: https://drive.google.com/file/d/1KC4fwvQudRRebi9DyNOVtRT2AmenL5ek/view?usp=sharing 
      
      3.Install a cluster on vSphere without TechPreview, we use flexy-template: ipi-on-vsphere/versioned-installer, there is no CPMS by default. 
      liuhuali@Lius-MacBook-Pro huali-test % oc get clusterversion                                                      
      NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS
      version   4.15.0-0.nightly-2023-12-04-223539   True        False         16m     Cluster version is 4.15.0-0.nightly-2023-12-04-223539
      liuhuali@Lius-MacBook-Pro huali-test % oc project openshift-machine-api
      Now using project "openshift-machine-api" on server "https://api.huliu-vs07c.qe.devcluster.openshift.com:6443".
      liuhuali@Lius-MacBook-Pro huali-test % oc get machine
      NAME                               PHASE     TYPE   REGION   ZONE   AGE
      huliu-vs07c-p6258-master-0         Running                          41m
      huliu-vs07c-p6258-master-1         Running                          41m
      huliu-vs07c-p6258-master-2         Running                          41m
      huliu-vs07c-p6258-worker-0-78zxg   Running                          36m
      huliu-vs07c-p6258-worker-0-tv2rw   Running                          36m
      liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset
      No resources found in openshift-machine-api namespace.
      
      4.Enable TechPreview, there is CPMS now, and itโ€™s Inactive
      liuhuali@Lius-MacBook-Pro huali-test % oc edit featuregate                                            
      featuregate.config.openshift.io/cluster edited
      liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset
      NAME      DESIRED   CURRENT   READY   UPDATED   UNAVAILABLE   STATE      AGE
      cluster   3         3         3                               Inactive   13m
      liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset cluster -oyaml
      โ€ฆ
              providerSpec:
                value:
                  apiVersion: machine.openshift.io/v1beta1
                  credentialsSecret:
                    name: vsphere-cloud-credentials
                  diskGiB: 120
                  kind: VSphereMachineProviderSpec
                  memoryMiB: 16384
                  metadata:
                    creationTimestamp: null
                  network:
                    devices: null
                  numCPUs: 4
                  numCoresPerSocket: 4
                  snapshot: ""
                  template: ""
                  userDataSecret:
                    name: master-user-data
                  workspace: {}
      
      5.Edit the CPMS, only change Inactive to Active. It triggers update, but it shouldnโ€™t, because I didnโ€™t change any configuration values.
      
      liuhuali@Lius-MacBook-Pro huali-test % oc edit controlplanemachineset                             
      controlplanemachineset.machine.openshift.io/cluster edited
      liuhuali@Lius-MacBook-Pro huali-test % oc get machine
      NAME                               PHASE          TYPE   REGION   ZONE   AGE
      huliu-vs07c-p6258-master-0         Running                               59m
      huliu-vs07c-p6258-master-1         Running                               59m
      huliu-vs07c-p6258-master-2         Running                               59m
      huliu-vs07c-p6258-master-ccgth-0   Provisioning                          8s
      huliu-vs07c-p6258-worker-0-78zxg   Running                               54m
      huliu-vs07c-p6258-worker-0-tv2rw   Running                               54m
      liuhuali@Lius-MacBook-Pro huali-test % oc logs control-plane-machine-set-operator-85595cdfdf-zh9bk
      โ€ฆ
      I1207 08:59:32.993680       1 updates.go:473]  "msg"="Machine requires an update" "controller"="controlplanemachineset" "diff"=["Template: /DEVQEdatacenter/vm/huliu-vs07c-p6258/huliu-vs07c-p6258-rhcos-generated-region-generated-zone != huliu-vs07c-p6258-rhcos-generated-region-generated-zone"] "index"=2 "name"="huliu-vs07c-p6258-master-2" "namespace"="openshift-machine-api" "reconcileID"="da8e7371-8378-42df-8a41-bc3f4198fb20" "updateStrategy"="RollingUpdate"
      
      
      Must gather: https://drive.google.com/file/d/1LL_anFTNsH5O4cIJSUzioyHphS_avyTP/view?usp=sharing 

      Actual results:

      The configuration values of the CPMS generated by installer on vSphere is not the same with the configuration values of the master machines

      Expected results:

      The configuration values of the CPMS generated by installer on vSphere should be the same with the configuration values of the master machines 

      Additional info:

          

            [OCPBUGS-24632] The configuration values of the CPMS generated by installer on vSphere is not the same with the master machines

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (Moderate: OpenShift Container Platform 4.15.32 bug fix and security update), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHSA-2024:6637

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (Moderate: OpenShift Container Platform 4.15.32 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2024:6637

            Gaoyun Pei added a comment -

            huliu@redhat.comSure, thanks for the checking!

            Gaoyun Pei added a comment - huliu@redhat.com Sure, thanks for the checking!

            Huali Liu added a comment -

            When trying to verify another related bug https://issues.redhat.com/browse/OCPBUGS-37064 , I also checked this bug, and seems the issue is fixed. so I think we can move this to Verified if you have no objection. gpei@redhat.com 

            For scenario 1, there is no network.devices, template and workspace in controlplanemachineset which is as expected, ref https://issues.redhat.com/browse/OCPBUGS-24632?focusedId=25088543&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-25088543 

            liuhuali@Lius-MacBook-Pro huali-test % oc get clusterversion
            NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS
            version   4.15.0-0.nightly-2024-09-09-175216   True        False         47m     Cluster version is 4.15.0-0.nightly-2024-09-09-175216 
            liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset
            NAME      DESIRED   CURRENT   READY   UPDATED   UNAVAILABLE   STATE    AGE
            cluster   3         3         3       3                       Active   78m
            liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset cluster -oyaml
            apiVersion: machine.openshift.io/v1
            kind: ControlPlaneMachineSet
            metadata:
              creationTimestamp: "2024-09-10T02:39:42Z"
              finalizers:
              - controlplanemachineset.machine.openshift.io
              generation: 1
              labels:
                machine.openshift.io/cluster-api-cluster: huliu-vs910d-xnhgx
              name: cluster
              namespace: openshift-machine-api
              resourceVersion: "20157"
              uid: 74f2be77-8fe2-4d49-b84e-6ed869b02a10
            spec:
              replicas: 3
              selector:
                matchLabels:
                  machine.openshift.io/cluster-api-cluster: huliu-vs910d-xnhgx
                  machine.openshift.io/cluster-api-machine-role: master
                  machine.openshift.io/cluster-api-machine-type: master
              state: Active
              strategy:
                type: RollingUpdate
              template:
                machineType: machines_v1beta1_machine_openshift_io
                machines_v1beta1_machine_openshift_io:
                  failureDomains:
                    platform: VSphere
                    vsphere:
                    - name: generated-failure-domain
                  metadata:
                    labels:
                      machine.openshift.io/cluster-api-cluster: huliu-vs910d-xnhgx
                      machine.openshift.io/cluster-api-machine-role: master
                      machine.openshift.io/cluster-api-machine-type: master
                  spec:
                    lifecycleHooks: {}
                    metadata: {}
                    providerSpec:
                      value:
                        apiVersion: machine.openshift.io/v1beta1
                        credentialsSecret:
                          name: vsphere-cloud-credentials
                        diskGiB: 120
                        kind: VSphereMachineProviderSpec
                        memoryMiB: 16384
                        metadata:
                          creationTimestamp: null
                        network:
                          devices: null
                        numCPUs: 4
                        numCoresPerSocket: 4
                        snapshot: ""
                        template: ""
                        userDataSecret:
                          name: master-user-data
                        workspace: {}
            status:
              conditions:
              - lastTransitionTime: "2024-09-10T02:45:07Z"
                message: ""
                observedGeneration: 1
                reason: AsExpected
                status: "False"
                type: Error
              - lastTransitionTime: "2024-09-10T02:50:34Z"
                message: ""
                observedGeneration: 1
                reason: AllReplicasAvailable
                status: "True"
                type: Available
              - lastTransitionTime: "2024-09-10T02:50:34Z"
                message: ""
                observedGeneration: 1
                reason: AsExpected
                status: "False"
                type: Degraded
              - lastTransitionTime: "2024-09-10T02:47:54Z"
                message: ""
                observedGeneration: 1
                reason: AllReplicasUpdated
                status: "False"
                type: Progressing
              observedGeneration: 1
              readyReplicas: 3
              replicas: 3
              updatedReplicas: 3

            For scenario 2, only active CPMS and do not change other configuration values will not trigger update now.

            liuhuali@Lius-MacBook-Pro huali-test % oc get clusterversion
            NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS
            version   4.15.0-0.nightly-2024-09-09-175216   True        False         146m    Cluster version is 4.15.0-0.nightly-2024-09-09-175216
            liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset
            No resources found in openshift-machine-api namespace.
            liuhuali@Lius-MacBook-Pro huali-test % oc edit featuregate                               
            featuregate.config.openshift.io/cluster edited
            liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset
            NAME      DESIRED   CURRENT   READY   UPDATED   UNAVAILABLE   STATE      AGE
            cluster   3         3         3       3                       Inactive   24m
            liuhuali@Lius-MacBook-Pro huali-test % oc edit controlplanemachineset   
            controlplanemachineset.machine.openshift.io/cluster edited
            liuhuali@Lius-MacBook-Pro huali-test % oc get machine
            NAME                                PHASE     TYPE   REGION   ZONE   AGE
            huliu-vs910c-df94j-master-0         Running                          4h59m
            huliu-vs910c-df94j-master-1         Running                          4h59m
            huliu-vs910c-df94j-master-2         Running                          4h59m
            huliu-vs910c-df94j-worker-0-8s7mn   Running                          3h53m
            huliu-vs910c-df94j-worker-0-jm5j9   Running                          4h52m
            liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset
            NAME      DESIRED   CURRENT   READY   UPDATED   UNAVAILABLE   STATE    AGE
            cluster   3         3         3       3                       Active   71m
            liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset cluster -oyaml
            apiVersion: machine.openshift.io/v1
            kind: ControlPlaneMachineSet
            metadata:
              creationTimestamp: "2024-09-10T06:23:03Z"
              finalizers:
              - controlplanemachineset.machine.openshift.io
              generation: 4
              name: cluster
              namespace: openshift-machine-api
              resourceVersion: "131888"
              uid: ff69fa31-a030-4b86-a0c6-335f3dac5518
            spec:
              replicas: 3
              selector:
                matchLabels:
                  machine.openshift.io/cluster-api-cluster: huliu-vs910c-df94j
                  machine.openshift.io/cluster-api-machine-role: master
                  machine.openshift.io/cluster-api-machine-type: master
              state: Active
              strategy:
                type: RollingUpdate
              template:
                machineType: machines_v1beta1_machine_openshift_io
                machines_v1beta1_machine_openshift_io:
                  failureDomains:
                    platform: VSphere
                    vsphere:
                    - name: generated-failure-domain
                  metadata:
                    labels:
                      machine.openshift.io/cluster-api-cluster: huliu-vs910c-df94j
                      machine.openshift.io/cluster-api-machine-role: master
                      machine.openshift.io/cluster-api-machine-type: master
                  spec:
                    lifecycleHooks: {}
                    metadata: {}
                    providerSpec:
                      value:
                        apiVersion: machine.openshift.io/v1beta1
                        credentialsSecret:
                          name: vsphere-cloud-credentials
                        diskGiB: 120
                        kind: VSphereMachineProviderSpec
                        memoryMiB: 16384
                        metadata:
                          creationTimestamp: null
                        network:
                          devices: null
                        numCPUs: 4
                        numCoresPerSocket: 4
                        snapshot: ""
                        template: ""
                        userDataSecret:
                          name: master-user-data
                        workspace: {}
            status:
              conditions:
              - lastTransitionTime: "2024-09-10T06:23:03Z"
                message: ""
                observedGeneration: 4
                reason: AsExpected
                status: "False"
                type: Error
              - lastTransitionTime: "2024-09-10T06:23:03Z"
                message: ""
                observedGeneration: 4
                reason: AllReplicasAvailable
                status: "True"
                type: Available
              - lastTransitionTime: "2024-09-10T06:23:03Z"
                message: ""
                observedGeneration: 4
                reason: AsExpected
                status: "False"
                type: Degraded
              - lastTransitionTime: "2024-09-10T07:13:43Z"
                message: ""
                observedGeneration: 4
                reason: AllReplicasUpdated
                status: "False"
                type: Progressing
              observedGeneration: 4
              readyReplicas: 3
              replicas: 3
              updatedReplicas: 3
            liuhuali@Lius-MacBook-Pro huali-test % 

            Huali Liu added a comment - When trying to verify another related bug https://issues.redhat.com/browse/OCPBUGS-37064 , I also checked this bug, and seems the issue is fixed. so I think we can move this to Verified if you have no objection. gpei@redhat.com   For scenario 1, there is no network.devices, template and workspace in controlplanemachineset which is as expected, ref https://issues.redhat.com/browse/OCPBUGS-24632?focusedId=25088543&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-25088543   liuhuali@Lius-MacBook-Pro huali-test % oc get clusterversion NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS version   4.15.0-0.nightly-2024-09-09-175216   True        False         47m     Cluster version is 4.15.0-0.nightly-2024-09-09-175216 liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset NAME      DESIRED   CURRENT   READY   UPDATED   UNAVAILABLE   STATE    AGE cluster   3         3         3       3                       Active   78m liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset cluster -oyaml apiVersion: machine.openshift.io/v1 kind: ControlPlaneMachineSet metadata:   creationTimestamp: "2024-09-10T02:39:42Z"   finalizers:   - controlplanemachineset.machine.openshift.io   generation: 1   labels:     machine.openshift.io/cluster-api-cluster: huliu-vs910d-xnhgx   name: cluster   namespace: openshift-machine-api   resourceVersion: "20157"   uid: 74f2be77-8fe2-4d49-b84e-6ed869b02a10 spec:   replicas: 3   selector:     matchLabels:       machine.openshift.io/cluster-api-cluster: huliu-vs910d-xnhgx       machine.openshift.io/cluster-api-machine-role: master       machine.openshift.io/cluster-api-machine-type: master   state: Active   strategy:     type: RollingUpdate   template:     machineType: machines_v1beta1_machine_openshift_io     machines_v1beta1_machine_openshift_io:       failureDomains:         platform: VSphere         vsphere:         - name: generated-failure-domain       metadata:         labels:           machine.openshift.io/cluster-api-cluster: huliu-vs910d-xnhgx           machine.openshift.io/cluster-api-machine-role: master           machine.openshift.io/cluster-api-machine-type: master       spec:         lifecycleHooks: {}         metadata: {}         providerSpec:           value:             apiVersion: machine.openshift.io/v1beta1             credentialsSecret:               name: vsphere-cloud-credentials             diskGiB: 120             kind: VSphereMachineProviderSpec             memoryMiB: 16384             metadata:               creationTimestamp: null             network:               devices: null             numCPUs: 4             numCoresPerSocket: 4             snapshot: ""             template: ""             userDataSecret:               name: master-user-data             workspace: {} status:   conditions:   - lastTransitionTime: "2024-09-10T02:45:07Z"     message: ""     observedGeneration: 1     reason: AsExpected     status: "False"     type: Error   - lastTransitionTime: "2024-09-10T02:50:34Z"     message: ""     observedGeneration: 1     reason: AllReplicasAvailable     status: "True"     type: Available   - lastTransitionTime: "2024-09-10T02:50:34Z"     message: ""     observedGeneration: 1     reason: AsExpected     status: "False"     type: Degraded   - lastTransitionTime: "2024-09-10T02:47:54Z"     message: ""     observedGeneration: 1     reason: AllReplicasUpdated     status: "False"     type: Progressing   observedGeneration: 1   readyReplicas: 3   replicas: 3   updatedReplicas: 3 For scenario 2, only active CPMS and do not change other configuration values will not trigger update now. liuhuali@Lius-MacBook-Pro huali-test % oc get clusterversion NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS version   4.15.0-0.nightly-2024-09-09-175216   True        False         146m    Cluster version is 4.15.0-0.nightly-2024-09-09-175216 liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset No resources found in openshift-machine-api namespace. liuhuali@Lius-MacBook-Pro huali-test % oc edit featuregate                                featuregate.config.openshift.io/cluster edited liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset NAME      DESIRED   CURRENT   READY   UPDATED   UNAVAILABLE   STATE      AGE cluster   3         3         3       3                       Inactive   24m liuhuali@Lius-MacBook-Pro huali-test % oc edit controlplanemachineset    controlplanemachineset.machine.openshift.io/cluster edited liuhuali@Lius-MacBook-Pro huali-test % oc get machine NAME                                PHASE     TYPE   REGION   ZONE   AGE huliu-vs910c-df94j-master-0         Running                          4h59m huliu-vs910c-df94j-master-1         Running                          4h59m huliu-vs910c-df94j-master-2         Running                          4h59m huliu-vs910c-df94j-worker-0-8s7mn   Running                          3h53m huliu-vs910c-df94j-worker-0-jm5j9   Running                          4h52m liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset NAME      DESIRED   CURRENT   READY   UPDATED   UNAVAILABLE   STATE    AGE cluster   3         3         3       3                       Active   71m liuhuali@Lius-MacBook-Pro huali-test % oc get controlplanemachineset cluster -oyaml apiVersion: machine.openshift.io/v1 kind: ControlPlaneMachineSet metadata:   creationTimestamp: "2024-09-10T06:23:03Z"   finalizers:   - controlplanemachineset.machine.openshift.io   generation: 4   name: cluster   namespace: openshift-machine-api   resourceVersion: "131888"   uid: ff69fa31-a030-4b86-a0c6-335f3dac5518 spec:   replicas: 3   selector:     matchLabels:       machine.openshift.io/cluster-api-cluster: huliu-vs910c-df94j       machine.openshift.io/cluster-api-machine-role: master       machine.openshift.io/cluster-api-machine-type: master   state: Active   strategy:     type: RollingUpdate   template:     machineType: machines_v1beta1_machine_openshift_io     machines_v1beta1_machine_openshift_io:       failureDomains:         platform: VSphere         vsphere:         - name: generated-failure-domain       metadata:         labels:           machine.openshift.io/cluster-api-cluster: huliu-vs910c-df94j           machine.openshift.io/cluster-api-machine-role: master           machine.openshift.io/cluster-api-machine-type: master       spec:         lifecycleHooks: {}         metadata: {}         providerSpec:           value:             apiVersion: machine.openshift.io/v1beta1             credentialsSecret:               name: vsphere-cloud-credentials             diskGiB: 120             kind: VSphereMachineProviderSpec             memoryMiB: 16384             metadata:               creationTimestamp: null             network:               devices: null             numCPUs: 4             numCoresPerSocket: 4             snapshot: ""             template: ""             userDataSecret:               name: master-user-data             workspace: {} status:   conditions:   - lastTransitionTime: "2024-09-10T06:23:03Z"     message: ""     observedGeneration: 4     reason: AsExpected     status: "False"     type: Error   - lastTransitionTime: "2024-09-10T06:23:03Z"     message: ""     observedGeneration: 4     reason: AllReplicasAvailable     status: "True"     type: Available   - lastTransitionTime: "2024-09-10T06:23:03Z"     message: ""     observedGeneration: 4     reason: AsExpected     status: "False"     type: Degraded   - lastTransitionTime: "2024-09-10T07:13:43Z"     message: ""     observedGeneration: 4     reason: AllReplicasUpdated     status: "False"     type: Progressing   observedGeneration: 4   readyReplicas: 3   replicas: 3   updatedReplicas: 3 liuhuali@Lius-MacBook-Pro huali-test %

            I had to rebase the changes.  Upon reviewing the changes ported back, I decided to make a change to the cluster-api-actuator-pkg in release-4.15 instead of updating go.mod to use 4.16 version.  That is sort of an oversight that was resulting in pulling newer versions of other dependencies that were not needed.  Once that PR merges, then the PR for the installer will be reviewed and merged.

            Neil Girard added a comment - I had to rebase the changes.  Upon reviewing the changes ported back, I decided to make a change to the cluster-api-actuator-pkg in release-4.15 instead of updating go.mod to use 4.16 version.  That is sort of an oversight that was resulting in pulling newer versions of other dependencies that were not needed.  Once that PR merges, then the PR for the installer will be reviewed and merged.

            Huali Liu added a comment -

            cc Richard Vanderpool to take a look, thanks! as I see you are the owner of the feature https://issues.redhat.com/browse/SPLAT-1110 

            Huali Liu added a comment - cc Richard Vanderpool to take a look, thanks! as I see you are the owner of the feature https://issues.redhat.com/browse/SPLAT-1110  

              rhn-support-ngirard Neil Girard
              huliu@redhat.com Huali Liu
              Gaoyun Pei Gaoyun Pei
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Created:
                Updated:
                Resolved: