Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-23398

HyperShift AWS KMS Backup key ARN incorrect

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done-Errata
    • Normal
    • 4.15.0
    • 4.15
    • HyperShift
    • No
    • Hypershift Sprint 246
    • 1
    • False
    • Hide

      None

      Show
      None
    • Hide
      Cause – Setting an AWS KMS Backup key ARN
      Consequence – AWS KMS Backup key ARN is never used
      Fix – correctly configure the backup KMS socket to used AWS KMS Backup key Result – Setting an AWS KMS Backup key ARN works as expected
      Show
      Cause – Setting an AWS KMS Backup key ARN Consequence – AWS KMS Backup key ARN is never used Fix – correctly configure the backup KMS socket to used AWS KMS Backup key Result – Setting an AWS KMS Backup key ARN works as expected
    • Bug Fix
    • In Progress

    Description

      Description of problem:

      AWS KMS on HyperShift makes use of two UNIX sockets via which the KMS plugins are run. Each unix socket should run connect to independent KMS instances i.e. with their own AWS ARNs. However, as of today both the active KMS socket as well as the backup KMS socket seem to be using the same ARN which essentially translates that the backup KMS instance never gets used. 

      Version-Release number of selected component (if applicable):

      HyperShift - main branch (PR #423)
      GitHub indicates all the following hypershift versions would be affected.
      v0.1.15, v0.1.14, v0.1.13,  v0.1.12, v0.1.11, v0.1.10, v0.1.9, v0.1.8, v0.1.7, v0.1.6, v0.1.5, v0.1.4, v0.1.3, v0.1.2, v0.1.1, v0.1.0, 2.0.0-20220406093220, 2.0.0-20220323110745, 2.0.0-20220319120001, 2.0.0-20220317155435 

      How reproducible:

      Always

      Steps to Reproduce:

      1. By creating a HyperShift cluster
      2. Checking if backup KMS instance was ever used
      

      Actual results:

      Active KMS instance's ARN is used even by the backup KMS socket

      Expected results:

      Backup KMS socket should use it's own backupKey.ARN

      Additional info:

      https://github.com/openshift/hypershift/blob/main/control-plane-operator/controllers/hostedcontrolplane/kas/aws_kms.go#L119

      should use backupKey.ARN instead of activeKey.ARN in the func call

      Attachments

        Activity

          People

            rh-ee-mraee Mulham Raee
            swghosh@redhat.com Swarup Ghosh
            Jie Zhao Jie Zhao
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: