-
Bug
-
Resolution: Done
-
Undefined
-
4.12
-
None
-
Quality / Stability / Reliability
-
False
-
-
None
-
Moderate
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
Description of problem:
Current steps for performance profile and tuned configs for worker do not fully work as expected. With the following change, a new performance profile is created, however the tuned is not referencing the new profile. Instead, it created a new tuned profile data entry in existing performance-patch Tuned, but still pointing to the old performance profile. https://github.com/openshift-kni/cnf-features-deploy/blob/b6364326cc298fb2e89867d65da226e053f4b3bd/ztp/gitops-subscriptions/argocd/SNOExpansion.md?plain=1#L287-L319 # New perf profile created [kni@registry.kni-qe-18 ~]$ oc get performanceprofiles.performance.openshift.io -A NAME AGE openshift-node-performance-profile 18h openshift-worker-node-performance-profile 116m # Added tuned profile data still includes the old perf profile [kni@registry.kni-qe-18 ~]$ oc get tuned -n openshift-cluster-node-tuning-operator performance-patch -o yaml apiVersion: tuned.openshift.io/v1 kind: Tuned metadata: creationTimestamp: "2022-10-12T21:58:49Z" generation: 4 name: performance-patch namespace: openshift-cluster-node-tuning-operator resourceVersion: "425680" uid: 4af906ae-b29a-4603-83a9-259d4a0a25f8 spec: profile: - data: | [main] summary=Configuration changes profile inherited from performance created tuned include=openshift-node-performance-openshift-node-performance-profile [bootloader] cmdline_crash=nohz_full=2-39,42-79 [sysctl] kernel.timer_migration=1 [service] service.stalld=start,enable service.chronyd=stop,disable name: performance-patch-worker - data: | [main] summary=Configuration changes profile inherited from performance created tuned include=openshift-node-performance-openshift-node-performance-profile [bootloader] cmdline_crash=nohz_full=2-39,42-79 [sysctl] kernel.timer_migration=1 [service] service.stalld=start,enable service.chronyd=stop,disable name: performance-patch recommend: - machineConfigLabels: machineconfiguration.openshift.io/role: master priority: 19 profile: performance-patch
Version-Release number of selected component (if applicable):
4.12
How reproducible:
100%
Steps to Reproduce:
1. Deploy a SNO via ZTP 2. Add a worker node via ZTP 3. Apply day2 configs on worker including performance profile and tuned config following https://github.com/openshift-kni/cnf-features-deploy/blob/b6364326cc298fb2e89867d65da226e053f4b3bd/ztp/gitops-subscriptions/argocd/SNOExpansion.md?plain=1#L287-L319
Actual results:
3. New performance profile created for worker, but tuned configs still points to old perf profile. 3. Nothing happens on worker with the performance profile.
Expected results:
Performance profile and tuned configs are applied on worker
Additional info:
Since both machine config pools we have out of ZTP applies to SNO node, in order to apply unique config on worker node, we probably need a machine config pool with a unique node selector that only selects the dedicated worker node. Meaning the added worker needs to have that unique label, and performance profile needs to be updated to use the unique label. Question is how do we create such mcp and node label via ZTP?
- links to
- mentioned on