Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-23247

LSO does not pass CVP tests

XMLWordPrintable

    • Yes
    • Approved
    • False
    • Hide

      None

      Show
      None
    • N/A
    • Release Note Not Required

      Description of problem:

      After https://github.com/openshift/local-storage-operator/pull/433, CVP test pipeline is failing with: 

      time="2023-11-14T08:19:28Z" level=error msg="Error: Value local.storage.openshift.io/v1, Kind=LocalVolume: owned CRD \"local.storage.openshift.io/v1, Kind=LocalVolume\" not found in bundle \"local-storage-operator.v4.15.0-202311140732\""
time="2023-11-14T08:19:28Z" level=error msg="Error: Value local.storage.openshift.io/v1alpha1, Kind=LocalVolumeSet: owned CRD \"local.storage.openshift.io/v1alpha1, Kind=LocalVolumeSet\" not found in bundle \"local-storage-operator.v4.15.0-202311140732\""
time="2023-11-14T08:19:28Z" level=error msg="Error: Value local.storage.openshift.io/v1alpha1, Kind=LocalVolumeDiscovery: owned CRD \"local.storage.openshift.io/v1alpha1, Kind=LocalVolumeDiscovery\" not found in bundle \"local-storage-operator.v4.15.0-202311140732\""
time="2023-11-14T08:19:28Z" level=error msg="Error: Value local.storage.openshift.io/v1alpha1, Kind=LocalVolumeDiscoveryResult: owned CRD \"local.storage.openshift.io/v1alpha1, Kind=LocalVolumeDiscoveryResult\" not found in bundle \"local-storage-operator.v4.15.0-202311140732\""
time="2023-11-14T08:19:28Z" level=warning msg="Warning: Value local.storage.openshift.io/v1alpha1, Kind=LocalVolumeDiscoveryResult: provided API should have an example annotation"
time="2023-11-14T08:19:28Z" level=warning msg="Warning: Value local-storage-operator.v4.15.0-202311140732: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for events: ([\"ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.ClusterPermissions[0].Rules[2]\" \"ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.ClusterPermissions[1].Rules[3]\" \"ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[5]\"])"

      This was reported on Slack, using "opm render" as a way to reproduce.

       

            [OCPBUGS-23247] LSO does not pass CVP tests

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (Critical: OpenShift Container Platform 4.15.0 security and extras update), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHSA-2023:7197

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (Critical: OpenShift Container Platform 4.15.0 security and extras update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:7197

            Jonathan Dobson added a comment -

            https://github.com/openshift/local-storage-operator/pull/445 merged and this build passed CVP:
            https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=2778285
            https://jenkins-cvp-5c79a5a8d70cc51dd4c37835.apps.ocp-c1.prod.psi.redhat.com/blue/organizations/jenkins/cvp-redhat-operator-bundle-image-validation-test/detail/cvp-redhat-operator-bundle-image-validation-test/73/pipeline/

            Jonathan Dobson added a comment - https://github.com/openshift/local-storage-operator/pull/445 merged and this build passed CVP: https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=2778285 https://jenkins-cvp-5c79a5a8d70cc51dd4c37835.apps.ocp-c1.prod.psi.redhat.com/blue/organizations/jenkins/cvp-redhat-operator-bundle-image-validation-test/detail/cvp-redhat-operator-bundle-image-validation-test/73/pipeline/

            OpenShift Jira Bot added a comment -

            Hi jdobson@redhat.com,

            Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.

            OpenShift Jira Bot added a comment - Hi jdobson@redhat.com , Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.

            Jonathan Dobson added a comment -

            Doh! From the build log, the ART pipeline uses a different (generated) bundle.Dockerfile:

            https://download.eng.bos.redhat.com/brewroot/packages/local-storage-operator-metadata-container/v4.15.0.202311101707.p0.g39fe975.assembly.stream/1/data/logs/x86_64-build.log

            Notice the first 3 steps:

            STEP 1/27: FROM scratch
STEP 2/27: COPY ./manifests /manifests
STEP 3/27: COPY ./metadata /metadata

            While in https://github.com/openshift/local-storage-operator/pull/433 I added a line `COPY crd/bases/*.yaml /manifests/` to copy the CRD's from a new location in bundle.Dockerfile:

            https://github.com/openshift/local-storage-operator/blob/39fe975114aa58a97d6aa0eab9840210b04db75a/config/bundle.Dockerfile#L10-L12

            So this works fine if using bundle.Dockerfile directly, but it apparently breaks the ART build because those CRD's are not copied from crd/bases/, it only copies manifests from the manifests-dir.

            Jonathan Dobson added a comment - Doh! From the build log, the ART pipeline uses a different (generated) bundle.Dockerfile: https://download.eng.bos.redhat.com/brewroot/packages/local-storage-operator-metadata-container/v4.15.0.202311101707.p0.g39fe975.assembly.stream/1/data/logs/x86_64-build.log Notice the first 3 steps: STEP 1/27: FROM scratch STEP 2/27: COPY ./manifests /manifests STEP 3/27: COPY ./metadata /metadata While in https://github.com/openshift/local-storage-operator/pull/433 I added a line `COPY crd/bases/*.yaml /manifests/` to copy the CRD's from a new location in bundle.Dockerfile: https://github.com/openshift/local-storage-operator/blob/39fe975114aa58a97d6aa0eab9840210b04db75a/config/bundle.Dockerfile#L10-L12 So this works fine if using bundle.Dockerfile directly, but it apparently breaks the ART build because those CRD's are not copied from crd/bases/, it only copies manifests from the manifests-dir .

              jdobson@redhat.com Jonathan Dobson
              rhn-engineering-jsafrane Jan Safranek
              Chao Yang Chao Yang
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Created:
                Updated:
                Resolved: