Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-23084

Test "start build with broken proxy should start a build and wait for the build to fail [apigroup:build.openshift.io]" is too loose with checking for errors


    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • 4.15.0
    • 4.15
    • Test Framework
    • None
    • No
    • 3
    • False
    • Hide



      Description of problem:

      When the "start build with broken proxy should start a build and wait for the build to fail [apigroup:build.openshift.io]" test runs, it expects the build to exit with a failure before printing the text "clone" for its log.
      Part of attempting to add a variant of this test which exercises the same functionality using an unprivileged build involves turning up the logging level so that the builder will log information that the test can look for which confirms that it was run in an unprivileged mode.  I'd like for it to print the name under which it was invoked, so that it's easier to find where a particular container's output starts in the log, but that name is openshift-git-clone.  The log message which would indicate that the test failed includes the text "git clone", so I'd like to amend the test to fail when that text is found in the log instead.

      Version-Release number of selected component (if applicable):


      How reproducible:


      Steps to Reproduce:

      1. Modify the test to increase the logging level for its test build.
      2. Apply https://github.com/openshift/builder/pull/358 to the builder image.
      3. Run the test.

      Actual results:

      The test always fails (or "fails").

      Expected results:

      The test passes, unless we broke something somewhere.

      Additional info:


            rhn-engineering-dgoodwin Devan Goodwin
            rhn-engineering-nalin Nalin Dahyabhai
            0 Vote for this issue
            2 Start watching this issue