-
Bug
-
Resolution: Unresolved
-
Normal
-
None
-
4.14
-
No
-
False
-
Description of problem:
CVO prints incorrect log diffs because the diffs are modified before printing the log
How reproducible:
Always
Steps to Reproduce:
1. CVO reconciles on modified value 2. CVO prints incorrect diff
Expected results:
CVO prints logs thats accurate before modification
Additional info:
For example,
here https://github.com/openshift/cluster-version-operator/blob/master/lib/resourceapply/rbac.go#L33, we send data to function to check if things have changed.
and we then change the existing value along with setting modified as true
https://github.com/openshift/cluster-version-operator/blob/master/lib/resourcemerge/rbac.go#L15
similarly this exists in https://github.com/openshift/cluster-version-operator/blob/master/lib/resourcemerge/meta.go#L10 and other functions.
this results in incorrect diff when we eventually print in log
here https://github.com/openshift/cluster-version-operator/blob/master/lib/resourceapply/rbac.go#L38
this will require some work to fix the logging to make sure we're logging the stuff that is correct.
- split from
-
OCPBUGS-19391 CVO hotloops on ClusterRoleBinding cluster-baremetal-operator and ConfigMap openshift-machine-config-operator/kube-rbac-proxy
- Closed