Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-22456

CVO print incorrect logs due to log modification

XMLWordPrintable

    • No
    • False
    • Hide

      None

      Show
      None

      Description of problem:

      CVO prints incorrect log diffs because the diffs are modified before printing the log

      How reproducible:

      Always

      Steps to Reproduce:

      1. CVO reconciles on modified value 
      2. CVO prints incorrect diff

      Expected results:

      CVO prints logs thats accurate before modification 

      Additional info:

       

      For example,

      here https://github.com/openshift/cluster-version-operator/blob/master/lib/resourceapply/rbac.go#L33, we send data to function to check if things have changed.

      and we then change the existing value along with setting modified as true

      https://github.com/openshift/cluster-version-operator/blob/master/lib/resourcemerge/rbac.go#L15

       

      similarly this exists in https://github.com/openshift/cluster-version-operator/blob/master/lib/resourcemerge/meta.go#L10 and other functions. 

       

      this results in incorrect diff when we eventually print in log 

      here https://github.com/openshift/cluster-version-operator/blob/master/lib/resourceapply/rbac.go#L38

       

      this will require some work to fix the logging to make sure we're logging the stuff that is correct.

            rh-ee-asdas Ashwin Das
            pratikam Pratik Mahajan
            Yang Yang Yang Yang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: