The machine approver logged the following when not approving an OpenStack CAPI machine:

I0927 14:46:09.967052       1 controller.go:120] Reconciling CSR: csr-m6mr9
E0927 14:46:10.003340       1 csr_check.go:263] csr-m6mr9: failed to find machine for node mbooth-psi-87zjs-workers-qds22, cannot approve
I0927 14:46:10.003376       1 controller.go:232] csr-m6mr9: CSR not authorized
E0927 14:46:10.003437       1 controller.go:324] "Reconciler error" err="could not reconcile CSR: failed to find machine for node mbooth-psi-87zjs-workers-qds22" controller="certificatesigningrequest" controllerGroup="certificates.k8s.io" controllerKind="CertificateSigningRequest" CertificateSigningRequest="csr-m6mr9" namespace="" name="csr-m6mr9" reconcileID=4db3820a-b87f-46f7-8bbc-ec3419fb0e7a

This error message suggests to anybody who hasn't also read the source that machine mbooth-psi-87zjs-workers-qds22 does not exist. However, it isn't actually looking for a machine called mbooth-psi-87zjs-workers-qds22. It is actually looking for any machine with an InternalDNS record in its status for mbooth-psi-87zjs-workers-qds22. This important detail is impossible to guess from the log message, and without it the log message is extremely confusing.

The log message should state clearly exactly what it was looking for that it could not find. Specifically it should mention an InternalDNS address record.

4.14
 

1.
2.
3.