Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-19510

CI issue with cluster-dns-operator TestCoreDNSDaemonSetReconciliation

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Normal
    • 4.15.0
    • 4.15
    • Networking / DNS
    • None
    • Sprint 242
    • 1
    • No
    • Rejected
    • False
    • Hide

      None

      Show
      None
    • N/A
    • Release Note Not Required

    Description

      Description of problem:

      I noticed this in the logs at https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-dns-operator/373/pull-ci-openshift-cluster-dns-operator-master-e2e-aws-ovn-operator/1704287854600916992/build-log.txt:
      
      === RUN   TestCoreDNSDaemonSetReconciliation
      [controller-runtime] log.SetLogger(...) was never called, logs will not be displayed:
      goroutine 205 [running]:
      runtime/debug.Stack()
      	/usr/lib/golang/src/runtime/debug/stack.go:24 +0x65
      sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
      	/go/src/github.com/openshift/cluster-dns-operator/vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:59 +0xbd
      sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).WithName(0xc000061340, {0x182213b, 0x14})
      	/go/src/github.com/openshift/cluster-dns-operator/vendor/sigs.k8s.io/controller-runtime/pkg/log/deleg.go:147 +0x4c
      github.com/go-logr/logr.Logger.WithName({{0x1aa8468, 0xc000061340}, 0x0}, {0x182213b?, 0x0?})
      	/go/src/github.com/openshift/cluster-dns-operator/vendor/github.com/go-logr/logr/logr.go:336 +0x46
      sigs.k8s.io/controller-runtime/pkg/client.newClient(0xc000789200, {0x0, 0xc0001a7730, {0x1aa9d90, 0xc00011c700}, 0x0, {0x0, 0x0}, 0x0})
      	/go/src/github.com/openshift/cluster-dns-operator/vendor/sigs.k8s.io/controller-runtime/pkg/client/client.go:115 +0xb4
      sigs.k8s.io/controller-runtime/pkg/client.New(0xc000789200?, {0x0, 0xc0001a7730, {0x1aa9d90, 0xc00011c700}, 0x0, {0x0, 0x0}, 0x0})
      	/go/src/github.com/openshift/cluster-dns-operator/vendor/sigs.k8s.io/controller-runtime/pkg/client/client.go:101 +0x85
      github.com/openshift/cluster-dns-operator/pkg/operator/client.NewClient(0x0?)
      	/go/src/github.com/openshift/cluster-dns-operator/pkg/operator/client/client.go:52 +0x145
      github.com/openshift/cluster-dns-operator/test/e2e.getClient()
      	/go/src/github.com/openshift/cluster-dns-operator/test/e2e/utils.go:451 +0x77
      github.com/openshift/cluster-dns-operator/test/e2e.TestCoreDNSDaemonSetReconciliation(0xc000501520)
      	/go/src/github.com/openshift/cluster-dns-operator/test/e2e/operator_test.go:330 +0x45
      testing.tRunner(0xc000501520, 0x193c038)
      	/usr/lib/golang/src/testing/testing.go:1576 +0x10b
      created by testing.(*T).Run
      	/usr/lib/golang/src/testing/testing.go:1629 +0x3ea
          operator_test.go:374: found "foo" node selector on daemonset openshift-dns/dns-default: <nil>
          operator_test.go:378: observed absence of "foo" node selector on daemonset openshift-dns/dns-default: <nil>
      --- PASS: TestCoreDNSDaemonSetReconciliation (1.63s)
      

      We need to make a minor change in https://github.com/openshift/cluster-dns-operator/blob/7d2a16c0abf80d09fdcbeef8464994b78aa0589d/test/e2e/operator_test.go#L374-L375

      Version-Release number of selected component (if applicable):

      4.15 and earlier
      

      How reproducible:

      Be unlucky in CI testing
      

      Steps to Reproduce:

      1.
      2.
      3.
      

      Actual results:

      Stack trace and prints a <nil>
       operator_test.go:374: found "foo" node selector on daemonset openshift-dns/dns-default: <nil>
          operator_test.go:378: observed absence of "foo" node selector on daemonset openshift-dns/dns-default: <nil>
      
      

      Expected results:

      No stack trace and no print of <nil>
      

      Additional info:

      
      

      Attachments

        Issue Links

          Activity

            People

              mmasters1@redhat.com Miciah Masters
              cholman@redhat.com Candace Holman
              Melvin Joseph Melvin Joseph
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated: