Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-18643

typo in 4.14/4.15 manifests_test.go

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Undefined Undefined
    • 4.16.0
    • 4.14.0, 4.15.0
    • Monitoring
    • None
    • Low
    • No
    • MON Sprint 250
    • 1
    • False
    • Hide

      None

      Show
      None
    • N/A
    • Release Note Not Required
    • In Progress

      Description of problem:

      found typo in 4.14/4.15 branch when review PR: https://github.com/openshift/cluster-monitoring-operator/pull/2073

      example typo in 4.14 branch

      https://github.com/openshift/cluster-monitoring-operator/blob/release-4.14/pkg/manifests/manifests_test.go

      1. systemd unit pattern valiation error
      valiation should be validation

      2. enable systemd collector with invalid units parttern
      parttern should be pattern

      3. t.Fatalf("invalid secret namepace, got %s, want %s", s.Namespace, "openshift-user-workload-monitoring")
      namepace should be namespace

      4. spread contraints
      should be spread constraints

      Version-Release number of selected component (if applicable):

      4.14/4.15

      How reproducible:

      always

      I remember we've added golang-lint to repo, it should find the errors

            [OCPBUGS-18643] typo in 4.14/4.15 manifests_test.go

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (Critical: OpenShift Container Platform 4.16.0 bug fix and security update), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHSA-2024:0041

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (Critical: OpenShift Container Platform 4.16.0 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2024:0041

            Junqi Zhao added a comment -

            fix merged to 4.16.0-0.nightly-2024-04-16-195622

            Junqi Zhao added a comment - fix merged to 4.16.0-0.nightly-2024-04-16-195622

            OpenShift Jira Bot added a comment -

            Hi prasriva@redhat.com,

            Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.

            OpenShift Jira Bot added a comment - Hi prasriva@redhat.com , Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.

            Pranshu Srivastava added a comment -

            This won't be back-ported due to obvious reasons.

            Pranshu Srivastava added a comment - This won't be back-ported due to obvious reasons.

              prasriva@redhat.com Pranshu Srivastava
              juzhao@redhat.com Junqi Zhao
              Junqi Zhao Junqi Zhao
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: