-
Bug
-
Resolution: Done-Errata
-
Normal
-
None
-
4.14
-
No
-
False
-
This is a clone of issue OCPBUGS-14356. The following is the description of the original issue:
—
Description of problem:
There are several labels used by the Nutanix platform which can vary between instances. If not set as ignore labels on the Cluster Autoscaler, features such as balancing similar node groups will not work predictably. The Cluster Autoscaler Operator should be updated with the following labels on Nutanix: * nutanix.com/prism-element-name * nutanix.com/prism-element-uuid * nutanix.com/prism-host-name * nutanix.com/prism-host-uuid for reference see this code: https://github.com/openshift/cluster-autoscaler-operator/blob/release-4.14/pkg/controller/clusterautoscaler/clusterautoscaler.go#L72-L159
Version-Release number of selected component (if applicable):
master, 4.14
How reproducible:
always
Steps to Reproduce:
1. create a ClusterAutoscaler CR on Nutanix platform 2. inspect the deployment for the cluster-autoscaler 3. see that it does not have the ignore labels added as command line flags
Actual results:
labels are not added as flags
Expected results:
labels should be added as flags
Additional info:
this should proabably be backported to 4.13 as well since the labels will be applied by the Nutanix CCM
- clones
-
-
- Closed
-
- is blocked by
-
-
- Closed
-
- links to
-
RHBA-2023:4456
OpenShift Container Platform 4.13.z bug fix update
[OCPBUGS-16768] Cluster Autoscaler Operator should inject unique labels on Nutanix platform
Milind Yadav
added a comment - Added test case and validated looks good , used the pre-merge build to verify [ Cluster version is 4.13.0-0.ci.test-2023-08-01-095345-ci-ln-tdqlbhk-latest]
clusterautoscaler pod has necessary labels as flags
spec: containers: - args: - --logtostderr - --record-duplicated-events - --cloud-provider=clusterapi - --namespace=openshift-machine-api - --leader-elect-lease-duration=137s - --leader-elect-renew-deadline=107s - --leader-elect-retry-period=26s - --scale-down-enabled=true - --scale-down-delay-after-add=10s - --scale-down-delay-after-delete=10s - --scale-down-delay-after-failure=10s - --scale-down-unneeded-time=10s - --balance-similar-node-groups=true - --balancing-ignore-label=nutanix.com/prism-element-name - --balancing-ignore-label=nutanix.com/prism-element-uuid - --balancing-ignore-label=nutanix.com/prism-host-name - --balancing-ignore-label=nutanix.com/prism-host-uuid
Milind Yadav
added a comment - Added test case and validated looks good , used the pre-merge build to verify [ Cluster version is 4.13.0-0.ci.test-2023-08-01-095345-ci-ln-tdqlbhk-latest]
clusterautoscaler pod has necessary labels as flags
spec:
containers:
- args:
- --logtostderr
- --record-duplicated-events
- --cloud-provider=clusterapi
- --namespace=openshift-machine-api
- --leader-elect-lease-duration=137s
- --leader-elect-renew-deadline=107s
- --leader-elect-retry-period=26s
- --scale-down-enabled= true
- --scale-down-delay-after-add=10s
- --scale-down-delay-after-delete=10s
- --scale-down-delay-after-failure=10s
- --scale-down-unneeded-time=10s
- --balance-similar-node-groups= true
- --balancing-ignore-label=nutanix.com/prism-element-name
- --balancing-ignore-label=nutanix.com/prism-element-uuid
- --balancing-ignore-label=nutanix.com/prism-host-name
- --balancing-ignore-label=nutanix.com/prism-host-uuid
Since the problem described in this issue should be resolved in a recent advisory, it has been closed.
For information on the advisory (Moderate: OpenShift Container Platform 4.13.8 bug fix and security update), and where to find the updated files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHSA-2023:4456