I just fixed an issue in clipHAProxyTimeout in OCPBUGS-6958, but we have a modified copy of it:
https://github.com/openshift/cluster-ingress-operator/blob/master/pkg/operator/controller/ingress/deployment.go#L1610

In addition, we convert fractionated values for env variables using durationToHAProxyTimespc, but not for annotations.

Should we fix the same issues and use durationToHAProxyTimespec for annotations as well as environment variables?
Pros: remove overflow bug, and consistent formatting of environment variables and annotation values
Cons: may introduce upgrade issues 

4.14

See ocpbugs-6958

1. n/a
2.
3.

n/a

n/a

We apply the router package clipHAProxyTimeout to at least one env variable in the template, ROUTER_HARD_STOP_AFTER.  For all the other env variables, we use durationToHAProxyTimespec , https://github.com/openshift/cluster-ingress-operator/blob/master/pkg/operator/controller/ingress/deployment.go#L1653

The latter will convert fractionated values into the appropriate format, like the test in https://github.com/openshift/cluster-ingress-operator/blob/master/pkg/operator/controller/ingress/deployment_test.go#L1773 shows.