Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-15338

Race condition in failure domain mapping with on-delete policy

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • 4.14.0
    • 4.12.z
    • Cloud Compute / Unknown
    • None
    • No
    • CLOUD Sprint 238
    • 1
    • False
    • Hide

      None

      Show
      None
    • Hide
      * Previously, for clusters on which the Control Plane Machine Set Operator is configured to use the `OnDelete` update strategy, cached information about machines caused the Operator to balance machines incorrectly and place them in an unexpected failure domain during reconciliation. With this release, the Operator refreshes this information immediately before creating new machines so that it correctly identifies the failure domains to place machines in. (link:https://issues.redhat.com/browse/OCPBUGS-15338[*OCPBUGS-15338*])
      Show
      * Previously, for clusters on which the Control Plane Machine Set Operator is configured to use the `OnDelete` update strategy, cached information about machines caused the Operator to balance machines incorrectly and place them in an unexpected failure domain during reconciliation. With this release, the Operator refreshes this information immediately before creating new machines so that it correctly identifies the failure domains to place machines in. (link: https://issues.redhat.com/browse/OCPBUGS-15338 [* OCPBUGS-15338 *])
    • Bug Fix
    • Done

      Description of problem:

      We have seen unit tests flaking on the mapping within the OnDelete policy tests for the control plane machine set.

It turns out there is a race condition, and, given the right timing, if a reconcile is in progress while a machine is marked for deletion, the load balancing part of the algorithm fails to properly apply

      Version-Release number of selected component (if applicable):

       

      How reproducible:

       

      Steps to Reproduce:

      1.
2.
3.

      Actual results:

       

      Expected results:

       

      Additional info:

       

              joelspeed Joel Speed
              joelspeed Joel Speed
              Zhaohua Sun Zhaohua Sun
              Jeana Routh Jeana Routh
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: