Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-13914

allow removal of vsphereStorageDriver field in 4.14

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Normal Normal
    • 4.14.0
    • 4.14.0
    • Storage
    • None
    • Moderate
    • No
    • Storage Sprint 236, Storage Sprint 237
    • 2
    • False
    • Hide

      None

      Show
      None
    • Hide
      The vsphereStorageDriver field of the Storage operator object has been deprecated and will be removed in a future release. This field was used to opt in to CSI migration on {product-title} 4.13 vSphere clusters, but it has no effect on {product-title} 4.14 and newer clusters. (link:https://issues.redhat.com/browse/OCPBUGS-13914[*OCPBUGS-13914*])
      Show
      The vsphereStorageDriver field of the Storage operator object has been deprecated and will be removed in a future release. This field was used to opt in to CSI migration on {product-title} 4.13 vSphere clusters, but it has no effect on {product-title} 4.14 and newer clusters. (link: https://issues.redhat.com/browse/OCPBUGS-13914 [* OCPBUGS-13914 *])
    • Deprecated Functionality
    • Done

      Description of problem:

      The vsphereStorageDriver is deprecated and we should allow cluster admins to remove that field from the Storage object in 4.14.

This is the validation rule that prevents removing vsphereStorageDriver:
https://github.com/openshift/api/blob/0eef84f63102e9d2dfdb489b18fa22676f2bd0c4/operator/v1/types_storage.go#L42

This was originally put in place to ensure that CSI Migration is not disabled again once it has been enabled. However, in 4.14 there is no way to disable migration, and there is an explicit rule to prevent setting LegacyDeprecatedInTreeDriver. So it should be safe to allow removing the vsphereStorageDriver field in 4.14, as this will not disable migration, and the field will eventually be removed from the API in a future release.

      Version-Release number of selected component (if applicable):

      4.14.0

      How reproducible:

       

      Steps to Reproduce:

      1. Set vsphereStorageDriver in the Storage object
2. Try to remove vsphereStorageDriver

      Actual results:

      * spec: Invalid value: "object": VSphereStorageDriver is required once set

      Expected results:

      should be allowed

      Additional info:

       

              jdobson@redhat.com Jonathan Dobson
              jdobson@redhat.com Jonathan Dobson
              Rohit Patil Rohit Patil
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: