Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-1371

Check if metrics are stale for Ingress

XMLWordPrintable

    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • 1
    • Low
    • None
    • None
    • None
    • Rejected
    • Sprint 233, Sprint 236
    • 2
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description of problem

      Here is at least one place where metrics could be incorrectly updated: https://github.com/openshift/cluster-ingress-operator/blob/88d3c147ecf214120d1cb6ad60860fb7211fe2e1/pkg/operator/controller/ingress/status.go#L686-L710

      IngressStatusesEqual can return the wrong result even if statuses haven't changed, both because it checks TLSProfile and ObservedGeneration, and because the conditionsEqual still uses cmpopts.EquateEmpty.

      Version-Release number of selected component (if applicable)

      4.12 and earlier.

      How reproducible

      Steps to Reproduce

      Actual results

      Expected results

      Ingress should not update condition metrics if its condition didn't change.

              cholman@redhat.com Candace Holman
              cholman@redhat.com Candace Holman
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: