Bug 2085336 - [IPI-Azure] Fail to create the worker node which HyperVGenerations is V2 or V1 and vmNetworkingType is Accelerated

This is a clone of closed bug in bugzilla to allow backport of the bug in jira.

When special the worker vm which HyperVGenerations is V2, the worker node fails to be created.

Version: registry.ci.openshift.org/ocp/release:4.11.0-0.nightly-2022-05-11-054135

How reproducible:
always

Steps to Reproduce:
Specify the compute vm as ‘Standard_DC4s_v3’ (HyperVGenerations is ‘V2’) in install-config.yaml
Create the cluster

Actual results:
Fail to create the worker nodes
maxu-hy4-ndjmn-worker-eastus21-k955j Provisioning 3h43m
maxu-hy4-ndjmn-worker-eastus23-w8m9v Provisioning 3h43m

check the logs as the following:
oc logs -n openshift-machine-api machine-api-controllers-6f85d75-ld8sc -c machine-controller
I0512 09:54:10.521080 1 actuator.go:85] Creating machine maxu-hy5-9hmpj-worker-eastus21-4t2mf
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x18b7d4e]

goroutine 378 [running]:
github.com/openshift/machine-api-provider-azure/pkg/cloud/azure/actuators/machine.(*Reconciler).createNetworkInterface(0xc000647580, {0x1fbb2e8, 0xc000042390}, {0xc0008411a0, 0x28})
/go/src/github.com/openshift/machine-api-provider-azure/pkg/cloud/azure/actuators/machine/reconciler.go:509 +0x1ee
github.com/openshift/machine-api-provider-azure/pkg/cloud/azure/actuators/machine.(*Reconciler).CreateMachine(0xc000647580, {0x1fbb2e8, 0xc000042390})
/go/src/github.com/openshift/machine-api-provider-azure/pkg/cloud/azure/actuators/machine/reconciler.go:120 +0x105
github.com/openshift/machine-api-provider-azure/pkg/cloud/azure/actuators/machine.(*Reconciler).Create(0xc000647580, {0x1fbb2e8, 0xc000042390})
/go/src/github.com/openshift/machine-api-provider-azure/pkg/cloud/azure/actuators/machine/reconciler.go:98 +0x45
github.com/openshift/machine-api-provider-azure/pkg/cloud/azure/actuators/machine.(*Actuator).Create(0xc0006c03c0, {0x1, 0x1}, 0xc000b95d40)
/go/src/github.com/openshift/machine-api-provider-azure/pkg/cloud/azure/actuators/machine/actuator.go:96 +0x2c5
github.com/openshift/machine-api-operator/pkg/controller/machine.(*ReconcileMachine).Reconcile(0xc000522ff0, {0x1fbb358, 0xc00057e930}, {0xc000682eb8, 0x1c31b00}, {0xc000840630, 0x30})
/go/src/github.com/openshift/machine-api-provider-azure/vendor/github.com/openshift/machine-api-operator/pkg/controller/machine/controller.go:387 +0xab4
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0xc0001a2160, {0x1fbb358, 0xc00057e810}, {0xc000682eb8, 0x1c31b00}, {0xc000840630, 0x413894})
/go/src/github.com/openshift/machine-api-provider-azure/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:114 +0x26f
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc0001a2160, {0x1fbb2b0, 0xc00013a740}, {0x1b29c80, 0xc000316cc0})
/go/src/github.com/openshift/machine-api-provider-azure/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:311 +0x33e
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc0001a2160, {0x1fbb2b0, 0xc00013a740})
/go/src/github.com/openshift/machine-api-provider-azure/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266 +0x205
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
/go/src/github.com/openshift/machine-api-provider-azure/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227 +0x85
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2
/go/src/github.com/openshift/machine-api-provider-azure/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:223 +0x357

Expected results:
Install success. the worker nodes are created.

Additional info:
Now the default vmNetworkingType of the worker is "Accelerated", changed to “Basic”, worker nodes can be created.
Standard_DC8s_v3 as master vm type, is ok; as worker vm type failed.
Ref :
https://issues.redhat.com/browse/CORS-1916
 
https://issues.redhat.com/browse/SPLAT-205