Description of problem:
When import a Serverless Service from a git repository the topology shows an Open URL decorator also when "Add Route" checkbox was unselected (which is selected by default).
The created kn Route makes the Service available within the cluster and the created URL looks like this: http://nodeinfo-private.serverless-test.svc.cluster.local
So the Service is NOT accidentally exposed. It's "just" that we link an internal route that will not be accessible to the user.
This might happen also for Serverless functions import flow and the import container image import flow.
Version-Release number of selected component (if applicable):
Tested older versions and could see this at least on 4.10+
Steps to Reproduce:
- Install the OpenShift Serverless operator and create the required kn Serving resource.
- Navigate to the Developer perspective > Add > Import from Git
- Enter a git repository (like https://gitlab.com/jerolimov/nodeinfo
- Unselect "Add Route" and press Create
The topology shows the new kn Service with a Open URL decorator on the top right corner.
The button is clickable but the target page could not be opened (as expected).
The topology should not show an Open URL decorator for "private" kn Routes.
The topology sidebar shows similar information, we should maybe release the Link there as well with a Text+Copy button???
A fix should be tested as well with Serverless functions as container images!
When the user unselects the "Add route" option an additional label is added to the kn Service. This label could also be added and removed later. When this label is specified the Open URL decorator should not be shown: