Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-10688

Fix leak in go-controller service controller's top level cache

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Normal
    • None
    • 4.12.z
    • None
    • Moderate
    • No
    • SDN Sprint 234
    • 1
    • False
    • Hide

      None

      Show
      None

    Description

      This is a clone of issue OCPBUGS-7732. The following is the description of the original issue:

      Description of problem:

      When services are deleted, the services controller cache should also remove the service from its top level cache to avoid growing forever.
      
      While this is not an issue in 4.13 once the lb_cache rework merges [1], the 4.12 and older branches have this problem because that rework is meant for 4.13 only.
      
      [1]: https://github.com/ovn-org/ovn-kubernetes/pull/3387
      
      This is the location where alreadyApplied is not deleting the removal: 
      https://github.com/openshift/ovn-kubernetes/blob/cf9fb51510e1870961bf3a0f064b73536757a4f8/go-controller/pkg/ovn/controller/services/services_controller.go#L269
      
      It should do the similar changes depicted here (currently merged upstream):
      https://github.com/ovn-org/ovn-kubernetes/blob/cd78ae1af4657d38bdc41003a8737aa958d62b9d/go-controller/pkg/ovn/controller/services/services_controller.go#L322-L324
      
      

       

      Version-Release number of selected component (if applicable):

       

      How reproducible:

      100%

      Steps to Reproduce:

      1. create service -- use unique name
      2. remove service
      3. notice how alreadyApplied grows and never gets smaller
      4. repeat
      
      

      Actual results:

      ^^

      Expected results:

      alreadyApplied should not grow forever

      Additional info:

       

      Attachments

        Issue Links

          Activity

            People

              ffernand@redhat.com Flavio Fernandes (Inactive)
              openshift-crt-jira-prow OpenShift Prow Bot
              Michael Fiedler Michael Fiedler
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: