Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-10418

Case sensitivity issue when label "openshift.io/cluster-monitoring" set to 'True' on openshift-windows-machine-config-operator namespace


    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Minor Minor
    • 4.11.z
    • 4.12.z
    • Windows Containers
    • None
    • Moderate
    • No
    • 0
    • WINC - Sprint 234
    • 1
    • False
    • Hide



      This is a clone of issue OCPBUGS-10222. The following is the description of the original issue:

      Description of problem:

      WMCO seems to be ignoring cluster monitoring label when the value is set to 'True'. Can see the prometheus windows exporter service running on windows nodes added to cluster but no metrics are available on cluster monitoring prometheus server. Couldn't edit the label from web console, did not try to update via command line to see what the experience is. Ended up having to delete the machineset, uninstall WMCO, delete namespace. Basically re-install configure. Tested this in OCP 4.12 version on AWS, See the ansible playbook here in this repo WMCO. https://github.com/rprakashg-redhat/windemosThis seems to be the offending line of code -> https://github.com/openshift/windows-machine-config-operator/blame/d0035fd0b3224bc90b87d3b436c66bd484047db4/pkg/metrics/metrics.go#L256 Thanks to @mansikulkarni96 for tracking this downWhat did you expect to happen?Metrics from windows nodes available on Cluster monitoring prometheus server. Label value should be case insensitive. Should allow both 'True' and 'true'

      Version-Release number of selected component (if applicable):


      How reproducible:


      Steps to Reproduce:

      1. Set the cluster monitoring label value to 'True'
      2. Install WMCO
      3. Deploy Windows Machineset
      4. SSH into windows node verify prometheus windows exporter is running
      5. Login to OpenShift console, navigate to observe->metrics and type windows you will see no metrics

      Actual results:

      no metrics available for windows nodes

      Expected results:

      windows metrics available to query with prefix 'windows_*'

      Additional info:


            mohashai Mohammad Shaikh
            openshift-crt-jira-prow OpenShift Prow Bot
            Aharon Rasouli Aharon Rasouli
            0 Vote for this issue
            5 Start watching this issue