-
Story
-
Resolution: Unresolved
-
Undefined
-
None
-
None
-
None
-
3
-
True
-
-
False
-
-
User story
So that I don't forget to add labels to machine pools, as a user, I want to add a set of labels to all machine pools when creating an HCP cluster.
Acceptance criteria
NOTE: This will enable the same functionality that exists when creating a ROSA classic cluster. This functionality was removed for HCP clusters as part of HAC-4118
- When creating an HCP cluster, as a user, I am able to add node labels when defining machine pools
- On the wizard review step, the entered labels are shown
- On wizard submit, the labels are sent with the requestÂ
- Once the cluster has been created, all the initial machine pools have the label set during the wizard step.
Mockups
Â
Implementation details
As of right now, there are two ways to send node pool data at creation time. For example:
ROSA classic (currently HCP wizard sends data this way)
{
"nodes": {
"compute_machine_type": {
"id": "m5.xlarge"
},
"compute": 4,
"compute_labels": {
"labelkey": "labelvalue"
},
"availability_zones": [
"us-west-2b",
"us-west-2a"
]
},
"aws": {
"subnet_ids": [
"subnet-0d6defaed67ec2ef2",
"subnet-04bc94f966b36124a"
]
},
}
The API does allow you to send node pool data this way:
{
"nodes": {
"compute": 4,
"availability_zones": [
"us-west-2b",
"us-west-2a"
]
},
"aws": {
"subnet_ids": [
"subnet-0d6defaed67ec2ef2",
"subnet-04bc94f966b36124a"
]
},
"nodePools": [
{
"kind": "NodePool",
"replicas": 2,
"availability_zone": "us-west-2b",
"aws_node_pool": {
"instance_type": "m5.xlarge"
},
"subnet": "subnet-0d6defaed67ec2ef2",
"labels": {
"hello": "world"
}
},
{
"kind": "NodePool",
"replicas": 2,
"availability_zone": "us-west-2a",
"aws_node_pool": {
"instance_type": "m5.xlarge"
},
"subnet": "subnet-04bc94f966b36124a",
"labels": {
"hello": "world"
}
}
]
}
After OCM-982 has been completed, the developer will need confirmation with the API team as far as which method above is the expected way to send node pool data.
- relates to
-
HAC-4118 [Hypershift ROSA] Unable to create ROSA Hypershift cluster as wizard throws the error that node compute labels are not supported.
-
- Closed
-