Uploaded image for project: 'OCMUI - OpenShift Cluster Manager UI'
  1. OCMUI - OpenShift Cluster Manager UI
  2. OCMUI-855

[OCM UI] switch all spinners to PF Spinner

    • Icon: Story Story
    • Resolution: Done
    • Icon: Minor Minor
    • None
    • None
    • None
    • 3
    • False
    • True

      Acceptance Criteria:

      • Replace all 28 Insights spinners occurances with PF spinners
      • Looks like HTML is the same, just need to change the import?
      • Some props might not transfer and may need to do css/classnames or use new PF prop/attribute.

      History:

      • Kim D.
        Just a question. I've seen that both the redhat-cloud-cloud-services and the Patternfly spinner are used in the app. I think they look the same - but wondering if we want to pick one over the other.
         

      doc: https://github.com/RedHatInsights/frontend-components/blob/master/packages/components/doc/spinner.md
      same doc: https://consoledot.pages.redhat.com/frontend-components/dev/components/spinner.html
      ^ BTW consoledot.pages.redhat.com is the inner docs page for consoledot platform. for components, same as on github.

      PF code: https://github.com/patternfly/patternfly-react/blob/main/packages/react-core/src/components/Spinner/Spinner.tsx
      https://github.com/patternfly/patternfly/blob/main/src/patternfly/components/Spinner/spinner.scss

      🤷 Yes, we should be consistent, I don't know which if one is "better".
       
      Ooh, found this on https://coreos.slack.com/archives/C023VGW21NU/p1628163313116300?thread_ts=1628156290.107900&cid=C023VGW21NU from Aug 2021:

      Just a note here, you should really use the spinner from PatternFly at this point. The clouddot one is going to be deprecated soon

              Unassigned Unassigned
              dtaylor@redhat.com David Taylor
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: