Uploaded image for project: 'OCMUI - OpenShift Cluster Manager UI'
  1. OCMUI - OpenShift Cluster Manager UI
  2. OCMUI-694

review all API list requests for size=-1 OR pagination

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False

      Similarly to HAC-1174, we have many backend requests where we GET a collection, by default returning at most size=100 items, AND we don't do pagination — we don't repeat the request with page=2, 3, ...
      Those are bugs waiting to happen, once the collection gets big enough
      Random example:

      const getRoles = () => apiRequest({
        method: 'get',
        url: '/api/clusters_mgmt/v1/aws_infrastructure_access_roles/?search=state=\'valid\'',
      });
      

      In clusters list, the display is paginated, so we only need to fetch one page

      In most other places, we want all data. The backend implementation of the pagination API actually has bad performance (SDA-360), so fetching many pages one after the other is bad idea (plus risks inconsistent view). For most things, we should provide page: -1 parameter to get all data in one request.

              Unassigned Unassigned
              bpaskinc@redhat.com Beni Paskin-Cherniavsky (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: