Uploaded image for project: 'OCMUI - OpenShift Cluster Manager UI'
  1. OCMUI - OpenShift Cluster Manager UI
  2. OCMUI-3976

check-links script reports false negatives

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • True
    • OCMUI Team Sprint 280

      emalka@redhat.com mentioned dtaylor@redhat.com might have some context on this

      overview

      the link checker is broken, affecting local runs, CI checks, and the broken-links slack workflow - causing all to report higher number of errors than in reality.

      how to reproduce

      execute run/check-links.mjs.

      expected result

      all reported errors should be valid errors due to broken links. found redirects shouldn't be reported as errors.

      actual result

      links under the section "status 405 - method not allowed" aren't actually broken. links under the section "status 302 - found" are counted as errors.

      example output (only the false-negatives' URLs were retained here):

      Category                           Count
      ---------------------------------- ------
      Total URLs skipped                     0
      Success                              340
      Redirects                             63
      Redirects errors                       1
      Client errors (4xx)                    4
      Server errors (5xx)                    0
      Request errors                         0
      ---------------------------------- ------
      Total URLs checked                   407
      
      ...
      
      [Status 302 - Found (Resource temporarily at different URL)] -            5 URLs
      
        ...
      
        [Original URL] https://console.aws.amazon.com/route53/v2/hostedzones
        [Redirect URL] https://us-east-1.console.aws.amazon.com/route53/v2/hostedzones
        [Redirect URL Test] 405
      
      [Status 405 - Method Not Allowed (Request method not supported)] -  4 URLs
      
        [Original URL] https://console.aws.amazon.com/rosa/home
        [Original URL] https://console.aws.amazon.com/rosa/home#/get-started
        [Original URL] https://console.aws.amazon.com/ec2/home#SecurityGroups
        [Original URL] https://issues.redhat.com/projects/OCPBUGS/issues
      
      ...
      
      
      

              lkeren-ocm Lior Keren
              emalka@redhat.com Lyn M
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: