-
Story
-
Resolution: Done
-
Major
-
None
-
None
-
Product / Portfolio Work
-
5
-
False
-
-
False
-
-
-
OCMUI Center Team Sprint 273, OCMUI Center Team Sprint 274
User story:
As a user, I want the edit/add machine pool modal broken down into concise "chunks" so that I can see all related options on an average sized monitor and I can focus on related items.
Additional information
The purpose of this story is to just break the modal into subtabs. No functional changes are needed. AKA fields/form will behave as it does today but only location of the fields will be changed.
Acceptance criteria:
- The modal content (aka form fields) will be broken down into sub-tabs (see design for exact tabs and content in each tabs)
- If the user does not have the feature gate enabled, they will be shown the current add/edit machine pool modal (without the subtabs). If the user does have the feature gate enabled, they will be shown the new modal added as part of this story (with the subtabs).
- If no fields are available under a tab, then the entire sub tab will be hidden. For example if security group fields are not normally shown for a given cluster type then the security group tab would not be shown
- The first (Overview) tab will be shown initially when the user opens the modal
- The submit button will be disabled if there is any error on any of the fields in any of the tabs (current functionality)
- If there is a validation error for any value a warning will be shown to the user (current functionality)
- When users clicks on the primary add/edit button, a request is sent via the api (current functionality)
- If the API request is successful, the modal closes (current functionality)
- If there is an error submitting the changes, the error will be shown right above the save/add button and is available while viewing all tabs
Mockups/Design (if available)
See section 2.b of the design docs
Out of scope
Any changes to how the fields/form behaves or looks with the exception of the addition of subtabs and the location of the fields.
- The following sections on the design doc are out of scope for this story and will be addressed in additional stories:
upgrade management fields including max surge, max unavailable, and node drain timeout - The checkbox to allow for AWS tags.
- Any indicator on the tabs that there is an error on that tab
- Viewing AWS tags on the machine pool tab
------------------------------------------------------------------------------------------------------------------------
Implementation notes (if available)
The machine pool modal already seems to be fairly broken apart field sets. The expectation that the feature gate will point to a new modal using existing components.