-
Task
-
Resolution: Done
-
Undefined
-
None
-
None
-
None
-
False
-
-
False
-
-
-
OCMUI Core Sprint 261
Recently lint and unit tests were removed from Gitlab pipeline and added to the Jenkins script.
A few issues have arisen:
- GitLab will allow a MR to be merged even if the Jenkins job/script has failed, and since we moved lint & unit tests into Jenkins, this means there is the potential to merge a MR with failed unit tests!!
- The Jenkins log file is a step back in usability for devs. Pls see https://issues.redhat.com/browse/OCMUI-2442
For these reasons, I'm advocating restoring lint and unit test to the GitLab pipeline.
Yes, this means lint & unit tests will be run twice (once in GitLab, once in Jenkins), but I get the feeling the team is ok with this performance hit in our CI in order to ensure we don't merge MRs which shouldn't be merged!