Description of the Problem
The user has launched a ROSA hosted wizard flow , updated all required valid definitions from each step and finally reached to "Review and create" step. The user clicked "Edit YAML" option and removed the oidc-config and id key and value then tried to create the cluster.
Cluster installation was initiated from UI without any error from backend about the missing definition and cluster installation state is in waiting forever and never proceeded or thrown any error to user about this missing definition.
Hence it looks like we must need some way to control missing mandatory definition from yaml definition and followed cluster submissions. I'm not sure if there is always a way to capture or block the cluster submission from preflight check from backend in above or similar situations.
see the recording attached Screencast from 2024-10-17 12-13-47.mp4
How reproducible:
always
Steps to Reproduce:
- Open OCM UI staging
- Launch ROSA wizard(hosted flow).
- Fill all required definitions from each step and reach to "Review and create" page.
- Click "Edit YAML" button.
- Remove oidc-config key including the id key and its value pair from the YAML.
- Click "Create cluster" button
- See the behavior.
Actual results:
The cluster creation initiated without any error although mandatory oidc-config definition is missing. The cluster installation status is in waiting forever from UI.
Expected results:
The cluster installation initiation should be blocked during the cluster submission when the oid-config definition is missing. This could be done in following way (suggestions ony)
- Take care via YAML validation on mandatory fields during cluster submission.
- Explicit check from UI on missing definition and throw error dialog to user about the same during submission.
- Depend on preflight check from OCM backend about missing definition and throw the error to user during cluster submission.
- blocks
-
OCMUI-187 YAML Editor - HCP Cluster Creation
- To Do
-
OCMUI-2365 YAML editor scaffolding
- Closed
- is blocked by
-
OCMUI-2266 [Yaml Editor] Sidebar panel with schema
- In Progress