Uploaded image for project: 'OCMUI - OpenShift Cluster Manager UI'
  1. OCMUI - OpenShift Cluster Manager UI
  2. OCMUI-1588

Remove warnings & errors from unit tests - Tag nesting

    • 3
    • True
    • Hide

      As part of removing Enzyme a lot of the errors are being removed. This story should start only after OCMUI-529 and OCMUI-593 are completed and merged.

      Show
      As part of removing Enzyme a lot of the errors are being removed. This story should start only after OCMUI-529 and OCMUI-593 are completed and merged.
    • True
    • ACM Console Sprint 251

      The purpose of this task is to remove any warnings in the console for passing unit tests that indicate that there is improper tag nesting.

      For example

        Warning: validateDOMNesting(...): <button> cannot appear as a descendant of <button>.
      

        
       
      There are currently 18 instances of this warning when unit test are run.

      This indicates that HTML items are nested in an invalid way. More often than not - improper nesting is an accessibility issue. Removing this warning will most likely involve changing the components themselves to ensure that the HTML tags are properly nested.

       

      TESTING:

      In order to fix errors, some minor HTML changes will be needed (changed a <p> tag to a <div> tag). Recommend just running the automated test to ensure changes didn't break functionality (or test script).

       

      Secondly this will require changing the underlying HTML for the wizard review pages.  After the changes are implemented - the review page should behave like today.  For each wizard (OSD, ROSA classic, ROSA hosted) go to the review screen and verify that the sections expand and collapse as expected.

              kdoberst Kim Doberstein
              dtaylor@redhat.com David Taylor
              LAKSHMI SHIVANTHI AMARACHINTHA LAKSHMI SHIVANTHI AMARACHINTHA
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: