Uploaded image for project: 'OpenShift Application Platform Engineering'
  1. OpenShift Application Platform Engineering
  2. OAPE-28

[GA] Update route rejection reason when secret gets deleted

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • None

      Currently, router sets the rejection reason as ExternalCertificateSecretDeleted when the referenced secret gets deleted. As part of this issue, we want that reason to be updated to common ExternalCertificateValidationFailed since there isn't any strong requirement to keep two distinct reasons.

      https://github.com/openshift/router/blob/4d9b8c4afa6cd89b41f4bd5e7c09ccddd8679bc6/pkg/router/controller/route_secret_manager.go#L214

       

      Background:

      Due to the router's design (details in slack thread), it re-triggers the plugin chain with MODIFIED event (after the status is updated), leading to route status overwrite from ExternalCertificateSecretDeleted to ExternalCertificateValidationFailed see here. However, as per the Slack discussion, there isn't any requirement to keep both statuses, which solves the end-user's perspective of updating the route's status an extra time.

       

      Scope:

      This story is only scoped to update the rejection reason and not solve the root cause of the re-trigger with the MODIFIED event. 

       

              rh-ee-ckyal Chirag Kyal
              rh-ee-ckyal Chirag Kyal
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: