Uploaded image for project: 'OpenShift API for Data Protection'
  1. OpenShift API for Data Protection
  2. OADP-708

Validation should not require default secret name if VSL is not specified.

XMLWordPrintable

    • False
    • Hide

      None

      Show
      None
    • False
    • QE - Ack
    • oadp-operator-container-1.2.0-33
    • ToDo
    • 0
    • 0
    • Very Likely
    • 0
    • None
    • Unset
    • Unknown
    • No

      Currently if a bsl or vsl uses a cloud provider, we require that a secret has to exist with a default name, or to create some dummy empty secret.

      We should allow validation to pass without requiring default credential name when VSL is not specified.

      Example dpa that should not fail validation IMO.

      apiVersion: oadp.openshift.io/v1alpha1
      kind: DataProtectionApplication
      metadata: 
        creationTimestamp: '2022-08-09T22:38:03Z'
        generation: 1
        managedFields: 
          - apiVersion: oadp.openshift.io/v1alpha1
            fieldsType: FieldsV1
            fieldsV1:
              'f:spec':
                .: {}
                'f:backupLocations': {}
                'f:configuration':
                  .: {}
                  'f:restic':
                    .: {}
                    'f:enable': {}
                  'f:velero':
                    .: {}
                    'f:defaultPlugins': {}
                'f:features':
                  .: {}
                  'f:enableDataMover': {}
                'f:unsupportedOverrides':
                  .: {}
                  'f:openshiftPluginImageFqin': {}
            manager: kubectl-create
            operation: Update
            time: '2022-08-09T22:38:03Z'
          - apiVersion: oadp.openshift.io/v1alpha1
            fieldsType: FieldsV1
            fieldsV1:
              'f:status':
                .: {}
                'f:conditions': {}
            manager: manager
            operation: Update
            subresource: status
            time: '2022-08-09T22:38:03Z'
        name: velero-sample
        namespace: openshift-adp
        resourceVersion: '269293716'
        uid: aa5b0357-93e0-4f31-9441-e99531268753
      spec: 
        backupLocations: 
          - velero: 
              credential: 
                key: cloud
                name: cloud-credentials
              default: true
              objectStorage: 
                bucket: deepakvelero
                prefix: velero
              provider: gcp
        configuration: 
          restic: 
            enable: false
          velero: 
            defaultPlugins: 
              - openshift
              - gcp
        features: 
          enableDataMover: false
        unsupportedOverrides: 
          openshiftPluginImageFqin: 'quay.io/tkaovila/openshift-velero-plugin:gcs-credentials'
      status: 
        conditions: 
          - lastTransitionTime: '2022-08-09T22:38:03Z'
            message: Secret "cloud-credentials-gcp" not found
            reason: Error
            status: 'False'
            type: Reconciled
      
      

              marnold@redhat.com Matthew Arnold
              tkaovila@redhat.com Tiger Kaovilai
              Amos Mastbaum Amos Mastbaum
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: