Uploaded image for project: 'OpenShift API for Data Protection'
  1. OpenShift API for Data Protection
  2. OADP-5831

Do not restore failed or currently running jobs

XMLWordPrintable

    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • ToDo
    • 0
    • Very Likely
    • 0
    • None
    • Unset
    • Unknown
    • None

      Description of problem:

      Restore is currently restoring failed jobs, causing them to rerun if they have a restartPolicy: OnFailure.

We only ignore Job restorations if there is a completionTime, but outright failures do not have a completionTime.
https://github.com/openshift/velero/blob/konveyor-dev/pkg/restore/restore.go#L2155-L2163

Currently running jobs or jobs that have not hit their total completions are more of a question mark.

For anything meant to be periodic, cronjobs will continue to run those jobs post restore.

      Version-Release number of selected component (if applicable):

      1.4.3

      How reproducible:

      Restore with some failed jobs that have a OnFailure restart policy

      Actual results:

      The jobs all run again post migration

      Expected results:

      Do not restore jobs that are failed as this can trigger them to re-run with unintended side effects or consequences.

      Additional info:

      As a workaround, can exclude them using 'velero.io/exclude-from-backup=true' or completely exclude the jobs resource if that works.

              tkaovila@redhat.com Tiger Kaovilai
              rhn-support-mrobson Matt Robson
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: