Uploaded image for project: 'OpenShift API for Data Protection'
  1. OpenShift API for Data Protection
  2. OADP-5420

PostHooks Multiple Exec Hooks are ignored in HooksAttamps calculation

    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • ToDo
    • 0
    • Very Likely
    • 0
    • None
    • Unset
    • Unknown
    • None

      (wip) - it is velero 1.13 feture i thinks

      When running a restore (or backup)  with multiple  exec Pothooks, the Number Of attempts (and number of failures accordingly)  Is 1 for each pod, instead of <number of exec hooks> X <the number of pods>

      *In case on of the exec hooks fails, the pothooks phase to considered failed 

      Restore (note the number of attempts) 

      $ oc describe restore mysql-hooks-e2e -nopenshift-adp
      Name:         mysql-hooks-e2e
      Namespace:    openshift-adp
      Labels:       <none>
      Annotations:  <none>
      API Version:  velero.io/v1
      Kind:         Restore
      Metadata:
      ...
      elero-server
          Operation:       Update
          Time:            2025-01-05T09:57:05Z
        Resource Version:  73737788
        UID:               df690be9-b24c-40b7-a17a-5c7cb5812f50
      Spec:
        Backup Name:  mysql-hooks-e2e-d919b0d1-cb4a-11ef-9264-0c9a3c9340c2
        Excluded Resources:
          nodes
          events
          events.events.k8s.io
          backups.velero.io
          restores.velero.io
          resticrepositories.velero.io
          csinodes.storage.k8s.io
          volumeattachments.storage.k8s.io
          backuprepositories.velero.io
        Hooks:
          Resources:
            Included Namespaces:
              test-oadp-xx
            Name:  restore-hook-1
            Post Hooks:
              Exec:
                Command:
                  /usr/bin/sh
                  -c
                  echo 'This is a failed hook' && echo 'Err: hook execution failed' 1>&2 && exit 0 
                Exec Timeout:  4m0s
                On Error:      Continue
                Wait Timeout:  2m0s
              Exec:
                Command:
                  /usr/bin/sh
                  -c
                  echo 'This is a successful  hook' && echo 'Info: hook execution succeeded ' 1>&2 && exit 0
                Exec Timeout:    4m0s
                On Error:        Continue
                Wait Timeout:    2m0s
        Item Operation Timeout:  4h0m0s
      Status:
        Completion Timestamp:  2025-01-05T09:57:05Z
        Hook Status:
          Hooks Attempted:  1
        Phase:              Completed
        Progress:
          Items Restored:                   33
          Total Items:                      33
        Restore Item Operations Attempted:  2
        Restore Item Operations Completed:  2
        Start Timestamp:                    2025-01-05T09:56:00Z
        Warnings:                           7
      Events:                               <none> 

       

              sseago Scott Seago
              amastbau Amos Mastbaum
              Sachin Singla
              Amos Mastbaum Amos Mastbaum
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: