-
Bug
-
Resolution: Unresolved
-
Minor
-
OADP 1.3.4
-
3
-
False
-
-
False
-
ToDo
-
-
-
0
-
0.000
-
Very Likely
-
0
-
None
-
Unset
-
Unknown
-
None
Description of problem:
While verifying this bug https://issues.redhat.com/browse/OADP-3562. I noticed an issue even though the DPA had an error, all the resource such BSL and velero/nodeagent pod is getting created which should have been skipped. Attached details below:-
Version-Release number of selected component (if applicable):
OADP 1.3.4
How reproducible:
Always
Steps to Reproduce:
1. Create a secret without setting value for the AZURE_CLIENT_SECRET key. For example:-
AZURE_SUBSCRIPTION_ID=53aaa-8cba-6d1fefd54c8a AZURE_TENANT_ID=60a54e-dc3f6be6a7ee AZURE_CLIENT_ID=477795-37da3de3b31f AZURE_CLIENT_SECRET= AZURE_STORAGE_ACCOUNT_ACCESS_KEY=<<access key>> AZURE_RESOURCE_GROUP=oadpxc7ss-rg AZURE_CLOUD_NAME=AzurePublicCloud
2. Create a DPA resource.
$ oc get dpa -o yaml
apiVersion: v1
items:
- apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
creationTimestamp: "2024-10-16T09:58:59Z"
generation: 1
name: ts-dpa
namespace: openshift-adp
resourceVersion: "73789"
uid: 024cda0d-2642-4f2d-9fa5-695354861a8b
spec:
backupLocations:
- name: test
velero:
config:
resourceGroup: oadp-99001-4jh4v-rg
storageAccount: oadp990014jh4v
storageAccountKeyEnvVar: AZURE_STORAGE_ACCOUNT_ACCESS_KEY
subscriptionId: 53b8f551-f0fc-4bea-8cba-6d1fefd54c8a
credential:
key: cloud
name: cloud-credentials-azure
default: true
objectStorage:
bucket: oadp990014jh4v
prefix: velero
provider: azure
configuration:
velero:
defaultPlugins:
- azure
- openshift
- csi
status:
conditions:
- lastTransitionTime: "2024-10-16T09:59:00Z"
message: secret parsing error in key AZURE_CLIENT_SECRET
reason: Error
status: "False"
type: Reconciled
Actual results:
Resource such as BSL and velero/nodeAgent pod is deployed on the cluster even though dpa had an error.
$ oc get bsl
NAME PHASE LAST VALIDATED AGE DEFAULT
test Available 1s 3m48s true
$ oc get pod NAME READY STATUS RESTARTS AGE openshift-adp-controller-manager-6d6b5f5d8b-kvnmw 1/1 Running 0 4m23s velero-64df7f9bcf-x2b45 1/1 Running 0 75s
Expected results:
Resource should only be created when there is no error in DPA
Additional info: